From: Roland Dreier <rdreier@cisco.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Avoid integer overflow in page_is_ram()
Date: Mon, 15 Sep 2008 15:51:35 -0700 [thread overview]
Message-ID: <ada7i9df2fc.fsf@cisco.com> (raw)
In-Reply-To: <D5A2FA91-E013-41EF-BCB5-E2645C20A918@kernel.crashing.org> (Kumar Gala's message of "Mon, 15 Sep 2008 17:44:05 -0500")
> > #ifndef CONFIG_PPC64 /* XXX for now */
> > - return paddr < __pa(high_memory);
> > + return pfn < max_pfn;
> > #else
> > + unsigned long paddr = (pfn << PAGE_SHIFT);
>
> seems like this could be a phys_addr_t
Yes, it could I guess, but that would be an unrelated change, and I'm
not sure there's much point given this is in 64-bit-only code.
- R.
next prev parent reply other threads:[~2008-09-15 22:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 20:31 Patches added to powerpc.git master and powerpc-next branches Paul Mackerras
2008-09-15 20:43 ` [PATCH] powerpc: Avoid integer overflow in page_is_ram() Roland Dreier
2008-09-15 22:44 ` Kumar Gala
2008-09-15 22:51 ` Roland Dreier [this message]
2008-09-16 9:57 ` [PATCH v5 0/2] powerpc: Board support for GE Fanuc SBC610 Martyn Welch
2008-09-16 9:57 ` [PATCH v5 1/2] " Martyn Welch
2008-09-16 15:18 ` Kumar Gala
2008-09-16 9:57 ` [PATCH v5 2/2] powerpc: Default configuration " Martyn Welch
2008-09-16 15:18 ` Kumar Gala
2008-09-16 14:54 ` [PATCH v5 0/2] powerpc: Board support " Kumar Gala
2008-09-16 15:04 ` Martyn Welch
-- strict thread matches above, loose matches on Subject: below --
2008-08-27 2:26 mmap and ppc460gt vb
2008-08-27 3:24 ` Roland Dreier
2008-08-27 8:13 ` Arnd Bergmann
2008-08-27 23:13 ` vb
2008-08-28 0:11 ` Roland Dreier
2008-08-28 3:12 ` Roland Dreier
2008-08-30 3:39 ` [PATCH] powerpc: Avoid integer overflow in page_is_ram() Roland Dreier
2008-09-01 0:27 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7i9df2fc.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.