From: Roland Dreier <rdreier@cisco.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Dale Farnsworth <dale@farnsworth.org>,
Nicolas Pitre <nico@marvell.com>,
Tzachi Perelstein <tzachi@marvell.com>,
Manas Saksena <msaksena@marvell.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] [MV643XX_ETH] Remove SHARED_REGS register address bias
Date: Thu, 18 Oct 2007 20:46:58 -0700 [thread overview]
Message-ID: <ada7iljepfx.fsf@cisco.com> (raw)
In-Reply-To: <20071019021117.GG16037@xi.wantstofly.org> (Lennert Buytenhek's message of "Fri, 19 Oct 2007 04:11:17 +0200")
> +static void __iomem *mv643xx_eth_base;
> + return readl(((void __iomem *)mv643xx_eth_base) + offset);
Given the declaration of mv643xx_eth_base as void __iomem * already, I
don't understand why you need the cast to the same type here (and
elsewhere in the driver).
- R.
next prev parent reply other threads:[~2007-10-19 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 2:11 [PATCH 5/8] [MV643XX_ETH] Remove SHARED_REGS register address bias Lennert Buytenhek
2007-10-19 3:46 ` Roland Dreier [this message]
2007-10-19 11:09 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7iljepfx.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=msaksena@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nico@marvell.com \
--cc=tzachi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.