From: Roland Dreier <rdreier@cisco.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: RDMA/nes: Fix mis-merge
Date: Thu, 26 Mar 2009 16:53:25 -0700 [thread overview]
Message-ID: <ada8wmru9hm.fsf@cisco.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0903261639150.3994@localhost.localdomain> (Linus Torvalds's message of "Thu, 26 Mar 2009 16:41:15 -0700 (PDT)")
> Btw, as far as I can tell, that function had never been tested with any
> polling. It had a line like
>
> netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
>
> but that line was _before_ 'nesvnic' was actually initialized (well, it
> had been initialized to NULL, so it passed in some NULL-pointer-offset to
> that function).
Yes, looks like the bug was introduced by d0929553 ("infiniband: convert
nes driver to net_device_ops"). And unfortunately the nesvnic=NULL
initialization stopped gcc from warning about used-uninitialized I
guess. I'll test the final merge out...
- R.
next prev parent reply other threads:[~2009-03-26 23:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 9:07 [GIT]: Networking for 2.6.30 David Miller
2009-03-26 9:07 ` David Miller
2009-03-26 9:41 ` Lorenzo Allegrucci
2009-03-26 9:41 ` Lorenzo Allegrucci
2009-03-26 22:25 ` David Miller
2009-03-26 22:56 ` Linus Torvalds
2009-03-26 23:00 ` David Miller
2009-03-26 23:25 ` RDMA/nes: Fix mis-merge Roland Dreier
2009-03-26 23:31 ` David Miller
2009-03-26 23:38 ` Linus Torvalds
2009-03-26 23:41 ` Linus Torvalds
2009-03-26 23:53 ` Roland Dreier [this message]
2009-03-27 7:29 ` David Miller
2009-03-26 23:48 ` Roland Dreier
2009-03-27 19:16 ` [PATCH] " Roland Dreier
2009-03-27 21:41 ` Linus Torvalds
2009-03-27 22:15 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada8wmru9hm.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.