All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: len.brown@intel.com, ibm-acpi@hmh.eng.br,
	ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)
Date: Mon, 04 Feb 2008 14:13:09 -0800	[thread overview]
Message-ID: <ada8x20gykq.fsf@cisco.com> (raw)
In-Reply-To: <47A78CBB.2090401@tiscali.nl> (Roel Kluin's message of "Mon, 04 Feb 2008 23:07:55 +0100")

 >                 /* safety net should the EC not support AUTO
 >                  * or FULLSPEED mode bits and just ignore them */
 >                 if (level & TP_EC_FAN_FULLSPEED)
 >                         level |= 7;     /* safety min speed 7 */
 >                 else if (level & TP_EC_FAN_FULLSPEED)
 >                         level |= 4;     /* safety min speed 4 */
 > 
 > Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should
 > this be replaced by

Actually I suspect one of the two tests should be against TP_EC_FAN_AUTO
(based on the comment).

  reply	other threads:[~2008-02-04 22:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 22:07 [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED) Roel Kluin
2008-02-04 22:13 ` Roland Dreier [this message]
2008-02-04 23:24   ` [PATCH][drivers/misc/thinkpad_acpi.c] " Roel Kluin
     [not found]     ` <47A79EC8.6060700-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
2008-02-05  5:05       ` Henrique de Moraes Holschuh
2008-02-05  5:05         ` Henrique de Moraes Holschuh
2008-02-05  8:34         ` Roel Kluin
2008-02-06 23:07           ` Greg KH
2008-02-06 23:48             ` Roel Kluin
2008-02-07  1:18               ` Henrique de Moraes Holschuh
2008-02-07  7:28                 ` [stable] " Greg KH
2008-02-07  5:55               ` Greg KH
2008-02-07  6:17       ` Len Brown
2008-02-07  6:17         ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada8x20gykq.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=12o3l@tiscali.nl \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.