From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from test-iport-1.cisco.com (test-iport-1.cisco.com [171.71.176.117]) by ozlabs.org (Postfix) with ESMTP id 7493C67B6E for ; Tue, 2 May 2006 03:13:34 +1000 (EST) To: Heiko Joerg Schick Subject: Re: [openib-general] Re: [PATCH 00/16] ehca: IBM eHCA InfiniBand Device Driver References: <4450B378.9000705@de.ibm.com> <20060427125726.GK32127@wohnheim.fh-wedel.de> From: Roland Dreier Date: Mon, 01 May 2006 10:03:24 -0700 In-Reply-To: (Heiko Joerg Schick's message of "Thu, 27 Apr 2006 21:50:28 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, openib-general@openib.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Heiko> I don't like the idea to put the whole driver in one patch Heiko> file. I would propose to put the patch "ehca: integration Heiko> in Linux kernel" last instead of first, as Arnd Heiko> mentioned. With that change we leave the kernel in a Heiko> working state when applying the patches. Yes, that makes sense. And I can fold the patches into a single git changeset when we finally merge it, since I don't see any advantage to having the driver split into pieces. (No one is going to git biset a half-applied driver or anything like that) - R. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbWEARD1 (ORCPT ); Mon, 1 May 2006 13:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932156AbWEARD1 (ORCPT ); Mon, 1 May 2006 13:03:27 -0400 Received: from test-iport-1.cisco.com ([171.71.176.117]:5674 "EHLO test-iport-1.cisco.com") by vger.kernel.org with ESMTP id S932154AbWEARD0 (ORCPT ); Mon, 1 May 2006 13:03:26 -0400 To: Heiko Joerg Schick Cc: openib-general@openib.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [openib-general] Re: [PATCH 00/16] ehca: IBM eHCA InfiniBand Device Driver X-Message-Flag: Warning: May contain useful information References: <4450B378.9000705@de.ibm.com> <20060427125726.GK32127@wohnheim.fh-wedel.de> From: Roland Dreier Date: Mon, 01 May 2006 10:03:24 -0700 In-Reply-To: (Heiko Joerg Schick's message of "Thu, 27 Apr 2006 21:50:28 +0200") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 01 May 2006 17:03:25.0432 (UTC) FILETIME=[28F89780:01C66D41] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Heiko> I don't like the idea to put the whole driver in one patch Heiko> file. I would propose to put the patch "ehca: integration Heiko> in Linux kernel" last instead of first, as Arnd Heiko> mentioned. With that change we leave the kernel in a Heiko> working state when applying the patches. Yes, that makes sense. And I can fold the patches into a single git changeset when we finally merge it, since I don't see any advantage to having the driver split into pieces. (No one is going to git biset a half-applied driver or anything like that) - R.