All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Linux RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [ofa-general][PATCH 1/4] SRP fail-over faster
Date: Wed, 14 Oct 2009 11:04:08 -0700	[thread overview]
Message-ID: <adaaaztam3r.fsf@cisco.com> (raw)
In-Reply-To: <4AD3B433.7040803-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> (Vu Pham's message of "Mon, 12 Oct 2009 15:56:51 -0700")

One meta comment: when sending a series of 4 patches, please choose a
descriptive subject for each one.  We don't want the same headline in
the kernel log for all 4 patches.

 > -	qp_attr.qp_state = IB_QPS_RESET;
 > -	ret = ib_modify_qp(target->qp, &qp_attr, IB_QP_STATE);
 > -	if (ret)
 > -		goto err;
 > -
 > -	ret = srp_init_qp(target, target->qp);
 > -	if (ret)
 > +	old_qp = target->qp;
 > +	old_cq = target->cq;
 > +	ret = srp_create_target_ib(target);

I don't understand why this is any faster?  Is creating a new QP really
any different from modifying an old QP to reset state?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-10-14 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 22:56 [ofa-general][PATCH 1/4] SRP fail-over faster Vu Pham
     [not found] ` <4AD3B433.7040803-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2009-10-14 18:04   ` Roland Dreier [this message]
     [not found]     ` <adaaaztam3r.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-14 19:52       ` Vu Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaaaztam3r.fsf@cisco.com \
    --to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.