From: Roland Dreier <rdreier@cisco.com>
To: Divy Le Ray <divy@chelsio.com>
Cc: netdev@vger.kernel.org
Subject: Re: Hitting slab BUG with bridging/cxgb3 on 2.6.31-rc2
Date: Wed, 08 Jul 2009 22:38:23 -0700 [thread overview]
Message-ID: <adaab3eza9c.fsf@cisco.com> (raw)
In-Reply-To: <adaeisqzawa.fsf@cisco.com> (Roland Dreier's message of "Wed, 08 Jul 2009 22:24:37 -0700")
> Yep, reverting that makes things work solid. I don't see an obvious
> problem with that patch... seems the only places that free TX skbs are
> the xmit routine itself, and in sge_timer_tx() where it's protected by
> doing __netif_tx_lock().
Looking a little deeper -- it seems that at least the msix interrupt
routines do look at txq stuff without taking the tx_lock, and possibly
wake the tx queue racily maybe....
Oh well, I'll let you stare at it a little now...
- R.
next prev parent reply other threads:[~2009-07-09 5:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 22:44 Hitting slab BUG with bridging/cxgb3 on 2.6.31-rc2 Roland Dreier
2009-07-09 0:12 ` Roland Dreier
2009-07-09 0:32 ` Roland Dreier
2009-07-09 1:38 ` Divy Le Ray
2009-07-09 5:24 ` Roland Dreier
2009-07-09 5:38 ` Roland Dreier [this message]
2009-07-09 19:30 ` [PATCH for 2.6.31] cxgb3: Fix crash caused by stashing wrong netdev_queue Roland Dreier
2009-07-09 21:15 ` Divy Le Ray
2009-07-09 23:16 ` Roland Dreier
2009-07-10 0:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaab3eza9c.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=divy@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.