All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: kobject must be initialized before calling kobject_init()?!
Date: Fri, 08 Feb 2008 20:24:25 -0800	[thread overview]
Message-ID: <adaabma21vq.fsf@cisco.com> (raw)

So I was perusing the code in lib/kobject.c, and I saw this:

	void kobject_init(struct kobject *kobj, struct kobj_type *ktype)
	{
		// [a couple of of parameter checks...]
		if (kobj->state_initialized) {
			/* do not error out as sometimes we can recover */
			printk(KERN_ERR "kobject (%p): tried to init an initialized "
			       "object, something is seriously wrong.\n", kobj);
			dump_stack();
		}

in other words the first thing you do is check a member of the
structure you're supposed to be initializing -- if someone just
kmalloc()s a struct kobject and passes it into this function, there's
a good chance that state_initialized won't be zero.  In fact, with
slab debugging on, it's guaranteed to be poisoned with a non-zero
value.

So are users supposed to be zeroing out struct kobjects before
initializing them?  If so, this should probably be documented.
And also the code in kobject_init() that sets other fields to be zero
can also be removed:

	kobj->state_in_sysfs = 0;
	kobj->state_add_uevent_sent = 0;
	kobj->state_remove_uevent_sent = 0;

Let me know if the intention is that everyone should zero out their
kobjects when they initialize them, and I'll send a patch updating the
documentation.

There's another similar booby-trap in kobject_init_and_add(), which
ends up calling into kobject_set_name_vargs(), which does

	/* Free the old name, if necessary. */
	kfree(kobj->name);

which is generally a bad thing if kobj->name has not been initialized.

Thanks,
  Roland

             reply	other threads:[~2008-02-09  4:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09  4:24 Roland Dreier [this message]
2008-02-09  5:15 ` kobject must be initialized before calling kobject_init()?! Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaabma21vq.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.