From: Roland Dreier <rdreier@cisco.com>
To: "Miguel Botón" <mboton.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
yi.zhu@intel.com, linville@tuxdriver.com
Subject: Re: [PATCH] iwlwifi: fix compilation warning in 'iwl-4965.c'
Date: Fri, 04 Jan 2008 14:13:12 -0800 [thread overview]
Message-ID: <adaabnlme87.fsf@cisco.com> (raw)
In-Reply-To: <200801042305.55188.mboton@gmail.com> (Miguel Botón's message of "Fri, 4 Jan 2008 23:05:54 +0100")
> - "radiotap head [%d]\n",
> + "radiotap head [%ld]\n",
> skb_headroom(skb), sizeof(*iwl4965_rt));
Actually I think the correct printf format for printing a size_t
(coming here from sizeof foo) is "%zd". Otherwise you'll fix the
warning on 64-bit targets but add a new warning on 32-bit targets.
- R.
next prev parent reply other threads:[~2008-01-04 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 22:05 [PATCH] iwlwifi: fix compilation warning in 'iwl-4965.c' Miguel Botón
2008-01-04 22:05 ` Miguel Botón
2008-01-04 22:13 ` Roland Dreier [this message]
2008-01-04 22:31 ` David Miller
2008-01-04 22:15 ` Randy Dunlap
2008-01-04 22:15 ` Randy Dunlap
2008-01-04 22:15 ` Michael Buesch
2008-01-04 22:15 ` Michael Buesch
2008-01-04 22:34 ` Miguel Botón
2008-01-04 22:34 ` Miguel Botón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaabnlme87.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mboton.lkml@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.