From: Roland Dreier <rdreier@cisco.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Eric Paris <eparis@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: O_* bit numbers uniqueness check
Date: Tue, 05 Jan 2010 23:30:31 -0800 [thread overview]
Message-ID: <adad41nvgfc.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100106071817.GA24428@localhost> (Wu Fengguang's message of "Wed, 6 Jan 2010 15:18:17 +0800")
> Yeah, I chose the boot time check because of hweight32()..
One could do something like
#define HWEIGHT32(x) (!!((x) & (1u << 0)) +
!!((x) & (1u << 1)) +
//...
!!((x) & (1u << 31)));
that would probably work with BUILD_BUG_ON().
But as I said maybe it's too ugly.
- R.
next prev parent reply other threads:[~2010-01-06 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 6:55 [PATCH] fs: O_* bit numbers uniqueness check Wu Fengguang
2010-01-06 7:07 ` Eric Dumazet
2010-01-06 7:07 ` Eric Dumazet
2010-01-06 7:20 ` Wu Fengguang
2010-01-06 9:13 ` Andreas Schwab
2010-01-09 13:33 ` Wu Fengguang
2010-01-09 13:33 ` Wu Fengguang
2010-01-06 7:08 ` Roland Dreier
2010-01-06 7:18 ` [PATCH v2] " Wu Fengguang
2010-01-06 7:30 ` Roland Dreier [this message]
2010-01-06 7:42 ` Wu Fengguang
2010-01-06 16:20 ` [PATCH] " Jamie Lokier
2010-01-09 13:44 ` Wu Fengguang
2010-01-06 15:48 ` Christoph Hellwig
2010-01-09 13:52 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adad41nvgfc.fsf@roland-alpha.cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.