From: Roland Dreier <rdreier@cisco.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Avi Kivity <avi@redhat.com>, Glauber Costa <glommer@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
aliguori@codemonkey.ws, npiggin@suse.de,
Jeremy Fitzhardinge <jeremy@goop.org>,
Krzysztof Helt <krzysztof.h1@poczta.fm>
Subject: Re: [PATCH] regression: vmalloc easily fail.
Date: Tue, 28 Oct 2008 15:03:20 -0700 [thread overview]
Message-ID: <adad4hkml7b.fsf@cisco.com> (raw)
In-Reply-To: <20081028144255.05712d70@infradead.org> (Arjan van de Ven's message of "Tue, 28 Oct 2008 14:42:55 -0700")
> I suspect it's a case of off-by-one... ALIGN() might round down, and
> the "+ (PAGE_SIZE-1)" was there to make it round up.
> Except for that missing -1 ...
ALIGN() has always rounded up, at least back to 2.4.
next prev parent reply other threads:[~2008-10-28 22:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 22:55 [PATCH] regression: vmalloc easily fail Glauber Costa
2008-10-28 21:03 ` Avi Kivity
2008-10-28 21:09 ` Glauber Costa
2008-10-28 21:22 ` Matias Zabaljauregui
2008-10-28 21:22 ` Roland Dreier
2008-10-28 21:42 ` Arjan van de Ven
2008-10-28 22:03 ` Roland Dreier [this message]
2008-10-28 23:29 ` Nick Piggin
2008-10-29 6:28 ` Avi Kivity
2008-10-29 9:48 ` Glauber Costa
2008-10-29 10:11 ` Nick Piggin
2008-10-29 10:29 ` Avi Kivity
2008-10-29 10:43 ` Nick Piggin
2008-10-29 22:07 ` Glauber Costa
2008-10-30 1:53 ` Nick Piggin
2008-10-30 4:49 ` Nick Piggin
2008-10-30 11:28 ` Glauber Costa
2008-10-31 7:16 ` Nick Piggin
2008-11-04 17:51 ` Glauber Costa
2008-11-05 0:21 ` Glauber Costa
2008-10-30 16:46 ` Matt Mackall
2008-10-30 18:04 ` Glauber Costa
2008-10-31 2:59 ` Nick Piggin
2008-11-07 20:37 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adad4hkml7b.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=aliguori@codemonkey.ws \
--cc=arjan@infradead.org \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jeremy@goop.org \
--cc=krzysztof.h1@poczta.fm \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.