From: Roland Dreier <rdreier@cisco.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
Date: Thu, 09 Mar 2006 15:24:13 -0800 [thread overview]
Message-ID: <adad5gvfbhe.fsf@cisco.com> (raw)
In-Reply-To: <eac2ad3017b5f160d24c.1141922822@localhost.localdomain> (Bryan O'Sullivan's message of "Thu, 9 Mar 2006 08:47:02 -0800")
> +static int ipath_sma_open(struct inode *in, struct file *fp)
> +{
> + int s;
> +
> + if (ipath_sma_alive) {
> + ipath_dbg("SMA already running (pid %u), failing\n",
> + ipath_sma_alive);
> + return -EBUSY;
> + }
> +
> + for (s = 0; s < atomic_read(&ipath_max); s++) {
> + struct ipath_devdata *dd = ipath_lookup(s);
> + /* we need at least one infinipath device to be initialized. */
> + if (dd && dd->ipath_flags & IPATH_INITTED) {
> + ipath_sma_alive = current->pid;
It seems there's a window here where two processes can both pass the
if (ipath_sma_alive) test and then proceed to step on each other.
- R.
next prev parent reply other threads:[~2006-03-09 23:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eac2ad3017b5f160d24c.1141922822@localhost.localdomain>
2006-03-09 23:20 ` [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management Roland Dreier
2006-03-09 23:39 ` Bryan O'Sullivan
2006-03-09 23:47 ` Roland Dreier
2006-03-09 23:50 ` Bryan O'Sullivan
2006-03-09 23:52 ` Roland Dreier
2006-03-10 15:54 ` Michael S. Tsirkin
2006-03-10 16:05 ` Bryan O'Sullivan
2006-03-09 23:24 ` Roland Dreier [this message]
2006-03-09 23:49 ` Bryan O'Sullivan
2006-03-09 23:51 ` Roland Dreier
2006-03-09 23:26 ` Roland Dreier
2006-03-09 23:52 ` Bryan O'Sullivan
2006-03-10 0:00 ` Roland Dreier
2006-03-10 0:04 ` Bryan O'Sullivan
2006-03-10 0:45 ` Greg KH
2006-03-10 0:48 ` Bryan O'Sullivan
2006-03-10 1:04 ` Greg KH
2006-03-10 4:41 ` Bryan O'Sullivan
2006-03-10 5:48 ` Greg KH
2006-03-10 13:40 ` Bryan O'Sullivan
2006-03-10 5:55 ` Roland Dreier
2006-03-10 13:43 ` Bryan O'Sullivan
2006-03-10 16:58 ` Greg KH
2006-03-10 17:05 ` Bryan O'Sullivan
2006-03-10 17:08 ` Roland Dreier
2006-03-10 17:32 ` Bryan O'Sullivan
2006-03-10 22:20 ` Roland Dreier
2006-03-10 0:35 [PATCH 0 of 20] [RFC] ipath driver - another round for review Bryan O'Sullivan
2006-03-10 0:35 ` [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management Bryan O'Sullivan
2006-03-10 0:45 ` Roland Dreier
2006-03-10 0:47 ` Bryan O'Sullivan
2006-03-10 0:52 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adad5gvfbhe.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.