From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24396C4707C for ; Fri, 12 Jan 2024 10:01:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9821F6B0089; Fri, 12 Jan 2024 05:01:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 932656B008A; Fri, 12 Jan 2024 05:01:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821858D0001; Fri, 12 Jan 2024 05:01:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 70F5A6B0089 for ; Fri, 12 Jan 2024 05:01:26 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3344E40C30 for ; Fri, 12 Jan 2024 10:01:26 +0000 (UTC) X-FDA: 81670216572.18.51DB40C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 707FD4002B for ; Fri, 12 Jan 2024 10:01:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705053684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3AERehBKtJDXxrvJKOOCqKWiukRKA4oA0QGteM7Q3zU=; b=FQmk8Vd8kW25ilwj+11kD2nF39kp674PjzTlo0Tfe69eweE9DLZ6mea4PP0MvxnLmpP7dw LuZqQRDIWKKAzEdEmzZNOApIG7t++8AYzTsZL+i4NQ0QF2gWcyl2l6j/a1jsuJv2cf4s7J 0d78GelgSubeD87P0fm699CujkzZWUQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705053684; a=rsa-sha256; cv=none; b=obNuBhfH2hp6K0df4TrXddvhCI6k4D5uKZUFck2A+UgPUKta5RsYlaQ8/OkBbho35+h2mK GpsNEkRzPzBClRKaCkerSFZ953SMb+yH0lIkvPbl7kW1EnWNEgeNvVqzzraQYrGPI/l/9T WYoKaZuMlObwzC0HbOYQJGwrUp3NUec= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE8142F4; Fri, 12 Jan 2024 02:02:09 -0800 (PST) Received: from [10.57.76.127] (unknown [10.57.76.127]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D74633F64C; Fri, 12 Jan 2024 02:01:21 -0800 (PST) Message-ID: Date: Fri, 12 Jan 2024 10:01:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] tools/mm: Add thpmaps script to dump THP usage info Content-Language: en-GB To: John Hubbard , Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , William Kucharski Cc: linux-mm@kvack.org, Barry Song References: <20240110173203.3419437-1-ryan.roberts@arm.com> <33341ca8-1354-4f3f-b377-0b7d04da48d0@nvidia.com> <43230798-af22-4f59-b37c-8257bae32af8@arm.com> <4eb4880c-d189-4576-8e2e-3deb40b5f8b0@nvidia.com> From: Ryan Roberts In-Reply-To: <4eb4880c-d189-4576-8e2e-3deb40b5f8b0@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 707FD4002B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 93fdf18m69e6b9wtux4t3dggc6o5jbuj X-HE-Tag: 1705053684-663306 X-HE-Meta: U2FsdGVkX1/fyrqE04pSBg7e1FHhO8fkfoK+UvBFFUKi/m6CS7H7JwrRe1Dcxxdm+HEcs1geuGrIp1lcNI+pnIHXdg5nF/512Ef9SormGUMC0Ft4oAhpZBkFj/9d+pugqzcUPJlGrMwHbUKy7wTbNkEGL3haTep8yOiPBNBzkMIHPfl8n82vmIX0BJI9/Pd3ant5jXzIQuq6Co9VgiV/6wVTzRHnrJBwcZWDk+tQg/LlIqCyK+F68loGVQiXWzN1G70Y8uqDXVDhUawDhBtQM4i2ocCzflGyV28KwgxRk24obob/pJZvIPnd6xGt6VRf758tbyugJscck+mxgtSVuOjKcgbBFOnT1O96rJPjDhXQtzLFkDaOjOCMoq4geS0ObbqRbgqBU3NiqSlOaamOpW04wv23/Rb4wpVNo1gZyJN5Ol2TlJLxccAGHESs0ETn9WRx3s6v+m1XXA0IKauMBzNyBHByOLowL2Y9bW24ZrE5QCR9RmFfD/O/hsTDLGdPMh1b9S2eDDBXlRrEluTl8FwIxlfwXqZGljkzh1s3iX/+TpqPY6iCpyvRpAs3UUy4RVbNn0Gmf/RTZu5DcjVu15nzYXP0eoREsZejGXSNApzK81tmjkd79YO/6XPaNwxXrCol7Fo1GgZhz9kkzEZUgMyOKO+IDI9Lt1YrBz0cDb4Ze4JLwZJy/lfd/2MOa8o+ydu0O9lyaaXcCP63wryinCAL3/7P+UarCV+gSnj933n+LUAy6q74tY7zPyb6yPL58c7IdruuQ94yi3lKdiUmx0d7x9lcFQP3Tf0XOUqQEIHUYi9f7/QznZITDIUlVAXc0sa/ZJu/zd0+oM43iq188/dRPAjSYMuUD6SBJypAsPNCllGF1WVZHg6SPv92djd2U9Zz/mGikD5QY5HFVU/aY0W/NdHPqRbEFCuwlEtyhZXcUZOXPTfaZKV3aD9Gw3xQSG7dRtztwWF1N/4ZwdI CygBCCA3 pXsq/k7AZWoX6s2W22T6iqqfumvxZxYDCWQLUP0rwZ0Z6vJISeZ0+ZjY7qlxrXXnkj+21eOurHwM8EUmgo7XHgsU1LM0e8Egyv/Lm/QXFbthNcM9+uTsdsCC1L3lu91nXEVAG9sqUtkpYSaDoJREq7bLXZlYpMVnoGFHyc7ZQG3pkrGE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/01/2024 18:04, John Hubbard wrote: > On 1/11/24 09:32, Ryan Roberts wrote: > ... >>> I have all the information to create a hugetlb-specific set of counters, so its >>> not lumped in with page cache memory. You would then have counter sets of >>> "anon", "file" and "htlb". Would that be useful? >> >> Or I could just filter out hugetlb memory so it doesn't appear in this tool at >> all? That would be easier implementation-wise, and probably more in line with >> the original intention of the tool (it's called thpmaps, after all). >> > > That does seem better. And I spend a fair amount of time explaining to > end users that hugetlbfs != THP, so that would also avoid aggravating that > problem as well. > Implemented for v3 > > thanks,