All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: rolandd@cisco.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] IB/mthca: replace dma_sync_single with dma_sync_single_for_cpu
Date: Thu, 28 May 2009 15:18:21 -0700	[thread overview]
Message-ID: <adaeiu86fde.fsf@cisco.com> (raw)
In-Reply-To: <20090528100943L.fujita.tomonori@lab.ntt.co.jp> (FUJITA Tomonori's message of "Thu, 28 May 2009 10:10:43 +0900")

 > This replaces dma_sync_single() with dma_sync_single_for_cpu() because
 > dma_sync_single() is an obsolete API; include/linux/dma-mapping.h says:
 > 
 > /* Backwards compat, remove in 2.7.x */

Thanks for pointing this out... however I think sync_single_for_cpu
looks wrong in these cases -- I think there should be a pair of
sync_single_for_cpu/sync_single_for_device around this stuff.

I'll take a closer look in the next day or too.

 - R.

  reply	other threads:[~2009-05-28 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28  1:10 [PATCH] IB/mthca: replace dma_sync_single with dma_sync_single_for_cpu FUJITA Tomonori
2009-05-28 22:18 ` Roland Dreier [this message]
2009-05-28 23:23   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaeiu86fde.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.