From: Roland Dreier <rdreier@cisco.com>
To: "Linsys Contractor Amit S. Kale" <amitkale@unminc.com>
Cc: netdev@vger.kernel.org, sanjeev@netxen.com, unmproj@linsyssoft.com
Subject: Re: [PATCH 8/9] Resending NetXen 1G/10G NIC driver patch
Date: Thu, 25 May 2006 09:44:13 -0700 [thread overview]
Message-ID: <adaejyijbqa.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0605250356420.5844-100000@unmsrvr> (Linsys Contractor Amit S. Kale's message of "Thu, 25 May 2006 03:57:31 -0700 (PDT)")
> +static int __devinit
> +netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> +#if defined(CONFIG_PCI_MSI)
> + adapter->flags |= NETXEN_NIC_MSI_ENABLED;
> + if (pci_enable_msi(pdev)) {
> + adapter->flags &= ~NETXEN_NIC_MSI_ENABLED;
> + printk(KERN_WARNING "%s: unable to allocate MSI interrupt"
> + " error\n", netxen_nic_driver_name);
> + }
> +#endif
No need for the #ifdef -- pci_enable_msi() is stubbed out so it will
always just return failure if CONFIG_PCI_MSI is not set.
> + adapterlist[netxen_cards_found++] = adapter;
> + adapter->number = netxen_cards_found;
Having a static array of adapters is a bad idea. Just allocate a
data structure for each card as you probe it.
- R.
next prev parent reply other threads:[~2006-05-25 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 10:57 [PATCH 8/9] Resending NetXen 1G/10G NIC driver patch Linsys Contractor Amit S. Kale
2006-05-25 16:44 ` Roland Dreier [this message]
2006-05-25 17:03 ` Stephen Hemminger
2006-05-26 14:26 ` Pradeep Dalvi
2006-05-26 16:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaejyijbqa.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=amitkale@unminc.com \
--cc=netdev@vger.kernel.org \
--cc=sanjeev@netxen.com \
--cc=unmproj@linsyssoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.