From: Roland Dreier <rdreier@cisco.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: Deadlock with icmpv6fuzz
Date: Thu, 05 Feb 2009 14:24:02 -0800 [thread overview]
Message-ID: <adafxisjzel.fsf@cisco.com> (raw)
In-Reply-To: <20090205143143.GA18734@alice> (Eric Sesterhenn's message of "Thu, 5 Feb 2009 15:31:43 +0100")
> [ 2880.044328] icmpv6fuzz: page allocation failure. order:9, mode:0x40d0
> [ 2880.044495] Pid: 10968, comm: icmpv6fuzz Not tainted
> 2.6.29-rc3-00580-ga2fe994-dirty #239
> [ 2880.044694] Call Trace:
> [ 2880.044802] [<c016886a>] __alloc_pages_internal+0x38e/0x3aa
> [ 2880.044954] [<c016889a>] __get_free_pages+0x14/0x24
> [ 2880.071336] [<c018412c>] __kmalloc+0x2e/0x122
> [ 2880.071589] [<c06fa227>] ipv6_flowlabel_opt+0x1e0/0x7b1
> [ 2880.092922] [<c06e8c9e>] ipv6_setsockopt+0xa0f/0xb89
>From a quick scan of the code, it looks as if optlen is never sanity
checked in the case of setsockopt(IPV6_FLOWLABEL_MGR), and
ipv6_flowlabel_opt() calls into fl_create() with whatever value
userspace passes in, which then pretty much does kmalloc(optlen).
So if icmpv6fuzz passes some big random value, it can cause this failure.
I don't know what the appropriate limit should be, so no patch, sorry.
- R.
next prev parent reply other threads:[~2009-02-05 22:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 20:47 Deadlock with icmpv6fuzz Eric Sesterhenn
2009-01-27 5:31 ` David Miller
2009-01-27 7:53 ` Eric Sesterhenn
2009-01-28 9:35 ` Herbert Xu
2009-01-30 1:49 ` David Miller
2009-02-05 13:01 ` Herbert Xu
2009-02-05 14:31 ` Eric Sesterhenn
2009-02-05 22:24 ` Roland Dreier [this message]
2009-02-05 23:43 ` Herbert Xu
2009-02-06 8:50 ` David Miller
2009-02-06 8:54 ` Herbert Xu
2009-02-06 9:05 ` David Miller
2009-02-06 9:22 ` Herbert Xu
2009-02-06 9:27 ` David Miller
2009-02-06 10:27 ` Herbert Xu
2009-02-06 10:34 ` Herbert Xu
2009-02-06 11:07 ` David Miller
2009-02-09 5:03 ` Herbert Xu
2009-02-09 6:04 ` David Miller
2009-02-25 7:44 ` David Miller
2009-02-25 8:25 ` Herbert Xu
2009-02-06 11:05 ` David Miller
2009-02-05 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafxisjzel.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.