From: Roland Dreier <rdreier@cisco.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: David Miller <davem@davemloft.net>,
shemminger@linux-foundation.org, netdev@vger.kernel.org,
themann@de.ibm.com, raisch@de.ibm.com
Subject: Re: new NAPI interface broken
Date: Wed, 19 Sep 2007 08:33:51 -0700 [thread overview]
Message-ID: <adafy1ak6u8.fsf@cisco.com> (raw)
In-Reply-To: <200709181815.45954.ossthema@de.ibm.com> (Jan-Bernd Themann's message of "Tue, 18 Sep 2007 18:15:45 +0200")
> One other thing I observed is that I can not unload the module as the
> ref counter of the eth device is too low. I haven't tracked down the
> source of this problem yet.
I suspect that this is because netif_rx_reschedule() was missing a
dev_hold() to match the dev_put() in netif_rx_complete(). Dave merged
a fix for that problem yesterday, so current net-2.6.24 should be OK.
Let us know if it's not OK, because then there's another bug...
- R.
next prev parent reply other threads:[~2007-09-19 15:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 9:37 new NAPI interface broken Jan-Bernd Themann
2007-09-12 12:50 ` David Miller
2007-09-12 13:10 ` new NAPI interface broken for POWER architecture? Christoph Raisch
2007-09-12 13:10 ` Christoph Raisch
2007-09-12 13:27 ` David Miller
2007-09-12 13:27 ` David Miller
2007-09-12 15:18 ` Arnd Bergmann
2007-09-12 15:18 ` Arnd Bergmann
2007-10-16 7:29 ` new NAPI interface broken Benjamin Herrenschmidt
2007-10-16 7:42 ` Benjamin Herrenschmidt
2007-10-16 7:44 ` David Miller
2007-10-16 8:28 ` Benjamin Herrenschmidt
2007-10-16 8:31 ` David Miller
2007-10-16 9:01 ` Benjamin Herrenschmidt
2007-10-16 21:01 ` Anton Blanchard
2007-10-17 15:26 ` Christoph Raisch
2007-10-16 15:56 ` Arjan van de Ven
2007-09-14 22:12 ` David Miller
2007-09-18 16:15 ` Jan-Bernd Themann
2007-09-18 19:08 ` David Miller
2007-09-19 15:33 ` Roland Dreier [this message]
2007-09-19 15:43 ` Jan-Bernd Themann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafy1ak6u8.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=shemminger@linux-foundation.org \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.