All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
Cc: pavel@suse.cz, rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
	axboe@kernel.dk,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bug 12713] Hang on resume from hibernation, apparently as result  of 213d9417fec
Date: Sun, 15 Feb 2009 17:28:42 -0800	[thread overview]
Message-ID: <adahc2v6ugl.fsf@cisco.com> (raw)
In-Reply-To: <8f53421d0902151607w2985dce6yc1bef7e717166fc@mail.gmail.com> (Michael S. Tsirkin's message of "Mon, 16 Feb 2009 02:07:59 +0200")

 > I haven't read the code in depth, but taking running numbers and doing
 > bitwise "or"
 > on them looks a bit strange to me.
 > So here BIO_RW_SYNC is (3 | 4) = 7, that is the same as BIO_RW_FAILFAST_DEV.
 > So for example bio_failfast_dev and bio_sync are the same.

Yes, this is clearly wrong.  The fix seems to be to delete the
definition of BIO_RW_SYNC, and everywhere that breaks, replace

	1 << BIO_RW_SYNC

with

	(1 << BIO_RW_SYNCIO) | (1 << BIO_RW_UNPLUG)

 - R.

  reply	other threads:[~2009-02-16  1:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16  0:05 [Bug 12713] Hang on resume from hibernation, apparently as result of 213d9417fec Michael S. Tsirkin
2009-02-16  0:07 ` Michael S. Tsirkin
2009-02-16  1:28   ` Roland Dreier [this message]
2009-02-16  1:28   ` Roland Dreier
2009-02-16  7:27   ` Jens Axboe
2009-02-16  7:27   ` Jens Axboe
2009-02-16  8:12     ` Michael S. Tsirkin
2009-02-16  8:12     ` Michael S. Tsirkin
2009-02-16  8:47       ` Jens Axboe
2009-02-16  8:47       ` Jens Axboe
2009-02-16 19:09         ` Michael S. Tsirkin
2009-02-16 19:09         ` Michael S. Tsirkin
2009-02-17 18:47           ` Jens Axboe
2009-02-17 18:47           ` Jens Axboe
2009-02-16  0:07 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2009-02-16  0:05 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adahc2v6ugl.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=axboe@kernel.dk \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=m.s.tsirkin@gmail.com \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.