From: Roland Dreier <rdreier@cisco.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix register_disk() when name has '/' in it
Date: Fri, 09 Jan 2009 22:11:34 -0800 [thread overview]
Message-ID: <adahc47ofl5.fsf@cisco.com> (raw)
In-Reply-To: <ac3eb2510901092208q1bbaca38xc1aefa9247b86f42@mail.gmail.com> (Kay Sievers's message of "Sat, 10 Jan 2009 07:08:01 +0100")
> > Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
> > dev_set_name()") deleted the code in register_disk() that changed a '/'
> > to a '!' in the device name when registering a disk.
>
> Hmm, this is done in the core, for all devices since a while:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f255651fb41c111ee35a2ae632df8ce9bd61def
>
> We should find what is going wrong here, instead of putting that code back.
The commit you point to is for kobject_set_name() ... but dev_set_name()
is still just setting dev->bus_id (at least in Linus's current tree).
If you want I can send a patch putting the conversion into
dev_set_name() for now instead.
- R.
next prev parent reply other threads:[~2009-01-10 6:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 5:57 [PATCH] block: Fix register_disk() when name has '/' in it Roland Dreier
2009-01-10 6:08 ` Kay Sievers
2009-01-10 6:11 ` Roland Dreier [this message]
2009-01-10 6:18 ` Kay Sievers
2009-01-10 6:27 ` [PATCH] driver core: Convert '/' to '!' in dev_set_name() Roland Dreier
2009-01-10 6:30 ` Kay Sievers
2009-01-11 6:52 ` Roland Dreier
2009-01-11 7:31 ` Greg KH
2009-01-15 22:49 ` Roland Dreier
2009-01-15 22:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahc47ofl5.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.