From: Roland Dreier <rdreier@cisco.com>
To: mporter@kernel.crashing.org
Cc: linuxppc-embedded@ozlabs.org
Subject: [PATCH] [POWERPC] Make ppc440spe_init_pcie() static
Date: Mon, 13 Nov 2006 09:57:02 -0800 [thread overview]
Message-ID: <adahcx344cx.fsf@cisco.com> (raw)
ppc440spe_init_pcie() is only called from the file where it's defined
(except for dead code, which we remove in this patch).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
Just a minor cleanup since I was looking at the code anyway. Please
queue for 2.6.20 too.
arch/ppc/platforms/4xx/yucca.c | 5 -----
arch/ppc/syslib/ppc440spe_pcie.c | 2 +-
arch/ppc/syslib/ppc440spe_pcie.h | 1 -
3 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/arch/ppc/platforms/4xx/yucca.c b/arch/ppc/platforms/4xx/yucca.c
index 346787d..6c60d53 100644
--- a/arch/ppc/platforms/4xx/yucca.c
+++ b/arch/ppc/platforms/4xx/yucca.c
@@ -239,11 +239,6 @@ yucca_setup_hoses(void)
char name[20];
int i;
- if (0 && ppc440spe_init_pcie()) {
- printk(KERN_WARNING "PPC440SPe PCI Express initialization failed\n");
- return;
- }
-
for (i = 0; i <= 2; ++i) {
if (!yucca_pcie_card_present(i))
continue;
diff --git a/arch/ppc/syslib/ppc440spe_pcie.c b/arch/ppc/syslib/ppc440spe_pcie.c
index 7ae14d2..fb0ddf1 100644
--- a/arch/ppc/syslib/ppc440spe_pcie.c
+++ b/arch/ppc/syslib/ppc440spe_pcie.c
@@ -159,7 +159,7 @@ static void check_error(void)
/*
* Initialize PCI Express core as described in User Manual section 27.12.1
*/
-int ppc440spe_init_pcie(void)
+static int ppc440spe_init_pcie(void)
{
int i;
diff --git a/arch/ppc/syslib/ppc440spe_pcie.h b/arch/ppc/syslib/ppc440spe_pcie.h
index 55b765a..23fe164 100644
--- a/arch/ppc/syslib/ppc440spe_pcie.h
+++ b/arch/ppc/syslib/ppc440spe_pcie.h
@@ -142,7 +142,6 @@ #define PECFG_PIM0LAH 0x344
#define PECFG_POM0LAL 0x380
#define PECFG_POM0LAH 0x384
-int ppc440spe_init_pcie(void);
int ppc440spe_init_pcie_rootport(int port);
void ppc440spe_setup_pcie(struct pci_controller *hose, int port);
--
1.4.3.2
reply other threads:[~2006-11-13 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahcx344cx.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.