From: Roland Dreier <rdreier@cisco.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [PATCH 2 of 20] ipath - core device driver
Date: Thu, 09 Mar 2006 15:22:22 -0800 [thread overview]
Message-ID: <adahd67fbkh.fsf@cisco.com> (raw)
In-Reply-To: <75d0a170fc9b4f016f8b.1141922815@localhost.localdomain> (Bryan O'Sullivan's message of "Thu, 9 Mar 2006 08:46:55 -0800")
> + if (dd->ipath_unit >= atomic_read(&ipath_max))
> + atomic_set(&ipath_max, dd->ipath_unit + 1);
If this is the way you use ipath_max, why is it an atomic variable? I
can't find any uses of ipath_max that don't look racy if the only
thing protecting it is the fact that it's an atomic_t, and if it has
some other protection, then I don't think it needs to be atomic.
- R.
next prev parent reply other threads:[~2006-03-09 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <75d0a170fc9b4f016f8b.1141922815@localhost.localdomain>
2006-03-09 17:54 ` [PATCH 2 of 20] ipath - core device driver Roland Dreier
2006-03-09 23:22 ` Roland Dreier [this message]
2006-03-10 0:35 [PATCH 0 of 20] [RFC] ipath driver - another round for review Bryan O'Sullivan
2006-03-10 0:35 ` [PATCH 2 of 20] ipath - core device driver Bryan O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adahd67fbkh.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.