From: Roland Dreier <rdreier@cisco.com>
To: Greg KH <gregkh@suse.de>
Cc: Andreas Mohr <andi@lisas.de>, Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [BUG] git 2.6.31-rc3'ish: "<kobject> does not have a release() function, it is broken and must be fixed."
Date: Thu, 06 Aug 2009 16:47:31 -0700 [thread overview]
Message-ID: <adaiqh0ec8c.fsf@cisco.com> (raw)
In-Reply-To: <20090806223205.GD14792@suse.de> (Greg KH's message of "Thu, 6 Aug 2009 15:32:05 -0700")
> Kay, we were cleaning up the kobject name stuff then, and we thought
> that this release function wasn't used anymore. But in looking at the
> code, I can't see where the kobject is actually freed. What am I
> missing?
the kobject in question is freed at
free_module() ->
mod_kobject_remove() ->
mod_sysfs_fini() ->
kobject_put(&mod->mkobj.kobj);
(in kernel/module.c)
Of course the release function you removed in 7a6a4161 was empty so it
wasn't doing anything except satisfying the "all kobjects must have a
release method" diktat.
- R.
next prev parent reply other threads:[~2009-08-06 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 18:12 [BUG] git 2.6.31-rc3'ish: "<kobject> does not have a release() function, it is broken and must be fixed." Andreas Mohr
2009-07-16 22:55 ` Greg KH
2009-08-06 20:28 ` Roland Dreier
2009-08-06 20:50 ` Andreas Mohr
2009-08-06 22:32 ` Greg KH
2009-08-06 23:47 ` Roland Dreier [this message]
2009-08-06 23:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaiqh0ec8c.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=andi@lisas.de \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.