From: Roland Dreier <rdreier@cisco.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Remove extra KERN_INFO in the middle of a line
Date: Tue, 13 Jan 2009 16:13:49 -0800 [thread overview]
Message-ID: <adaiqoikama.fsf@cisco.com> (raw)
In-Reply-To: <adamydukawi.fsf@cisco.com> (Roland Dreier's message of "Tue, 13 Jan 2009 16:07:41 -0800")
By the way, looking at nearby code:
else {
/* FIXME, make a readl uuid parser */
printk(KERN_INFO "device fsid %llx-%llx ",
*(unsigned long long *)disk_super->fsid,
*(unsigned long long *)(disk_super->fsid + 8));
}
aside from the readl typo here, it occurs to me that this is not
endian-safe, because AFAIK nothing ever swaps disk_super->fsid ... so
this would produce possibly confusing output if someone ever moved
storage with a btrfs filesystem on it from one endianness to another...
next prev parent reply other threads:[~2009-01-14 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 0:07 [PATCH] btrfs: Remove extra KERN_INFO in the middle of a line Roland Dreier
2009-01-14 0:13 ` Roland Dreier [this message]
2009-01-14 7:57 ` Pekka Enberg
2009-01-14 18:34 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaiqoikama.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=chris.mason@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.