From: Roland Dreier <rdreier@cisco.com>
To: "Zach Brown" <zach.brown@oracle.com>
Cc: "Michael S. Tsirkin" <mst@mellanox.co.il>,
"Andrew Morton" <akpm@osdl.org>, "Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org, openib-general@openib.org,
"Arjan van de Ven" <arjan@infradead.org>
Subject: Re: [openib-general] [PATCH] mthca: initialize send and receive queue locks separately
Date: Tue, 04 Jul 2006 13:39:34 -0700 [thread overview]
Message-ID: <adairmd9kah.fsf@cisco.com> (raw)
In-Reply-To: <44AA9999.3060308@oracle.com> (Zach Brown's message of "Tue, 04 Jul 2006 09:38:49 -0700")
Zach> Also, while looking at this I saw that the locks are being
Zach> re-initialized from mthca_modify_qp(). Is that just a
Zach> side-effect of relying on mthca_wq_init() to reset the
Zach> non-lock members? If you're concerned about
Zach> microoptimization it seems like this could be avoided.
I think that is actually a very minor bug you've found. If someone
were posting a work request at the same time as they transitioned a QP
to reset (which is a legitimate if not sensible thing to do), then the
spinlock could get reinitialized while it was held. Which would be
bad. So I think I like your original patch the best.
- R.
next prev parent reply other threads:[~2006-07-04 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 22:50 [PATCH] mthca: initialize send and receive queue locks separately Zach Brown
2006-07-04 7:03 ` Michael S. Tsirkin
2006-07-04 8:56 ` Ingo Molnar
2006-07-04 9:42 ` Michael S. Tsirkin
2006-07-04 11:56 ` Ingo Molnar
2006-07-04 12:52 ` Michael S. Tsirkin
2006-07-26 6:26 ` [PATCH] lockdep: don't pull in includes when lockdep disabled Michael S. Tsirkin
2006-07-26 6:33 ` Arjan van de Ven
2006-07-26 6:43 ` Michael S. Tsirkin
2006-07-26 7:13 ` Alexey Dobriyan
2006-07-04 16:38 ` [openib-general] [PATCH] mthca: initialize send and receive queue locks separately Zach Brown
2006-07-04 16:52 ` Michael S. Tsirkin
2006-07-04 20:39 ` Roland Dreier [this message]
2006-07-05 3:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adairmd9kah.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@mellanox.co.il \
--cc=openib-general@openib.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.