From: Roland Dreier <rdreier@cisco.com>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org, gallatin@myri.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] myri10ge - Driver core
Date: Wed, 17 May 2006 15:36:20 -0700 [thread overview]
Message-ID: <adairo446u3.fsf@cisco.com> (raw)
In-Reply-To: <20060517220608.GD13411@myri.com> (Brice Goglin's message of "Wed, 17 May 2006 18:06:10 -0400")
Still some suspicious uses of volatile here.
For example:
> +struct myri10ge_priv {
...
> + volatile u8 __iomem *sram;
as far as I can see this is always used with proper __iomem accessors,
often with casts to strip the volatile anyway. So why is volatile needed?
I would suggest an audit of all uses of volatile in the driver, since
"volatile" in drivers really should be read "there's probably a bug
here, and if not something very tricky is going on." If there are any
valid uses of volatile then a comment should explain why, so that
future reviewers don't have to try and puzzle out which of the
two possible translations of volatile is correct.
- R.
next prev parent reply other threads:[~2006-05-17 22:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 22:02 [PATCH 0/4] myri10ge - Myri-10G Ethernet driver - v2 Brice Goglin
2006-05-17 22:03 ` [PATCH 1/4] myri10ge - Revive pci_find_ext_capability Brice Goglin
2006-05-17 22:04 ` [PATCH 2/4] myri10ge - Driver header files Brice Goglin
2006-05-17 22:28 ` Randy.Dunlap
2006-05-18 23:36 ` Brice Goglin
2006-05-17 22:06 ` [PATCH 3/4] myri10ge - Driver core Brice Goglin
2006-05-17 22:36 ` Roland Dreier [this message]
2006-05-18 23:38 ` Brice Goglin
2006-05-17 23:08 ` Arnd Bergmann
2006-05-18 23:56 ` Brice Goglin
2006-05-19 1:55 ` Arnd Bergmann
2006-05-19 2:25 ` Brice Goglin
2006-05-19 10:00 ` Arnd Bergmann
2006-05-19 11:09 ` Andi Kleen
2006-05-19 15:48 ` Brice Goglin
2006-05-20 7:58 ` Brice Goglin
2006-05-19 14:39 ` Brice Goglin
2006-05-19 23:15 ` Brice Goglin
2006-05-20 0:01 ` Andi Kleen
2006-05-23 15:39 ` Anton Blanchard
2006-05-24 8:04 ` Brice Goglin
2006-05-24 21:21 ` Anton Blanchard
2006-05-25 7:59 ` Benjamin Herrenschmidt
2006-05-25 9:07 ` Brice Goglin
2006-05-25 7:56 ` Benjamin Herrenschmidt
2006-05-26 9:49 ` Ingo Oeser
2006-05-26 10:02 ` Benjamin Herrenschmidt
2006-05-26 10:30 ` Jeff Garzik
2006-05-26 10:56 ` Benjamin Herrenschmidt
2006-05-17 22:07 ` [PATCH 4/4] myri10ge - Kconfig and Makefile Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adairo446u3.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.