From: Roland Dreier <rdreier@cisco.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: Andrew Morton <akpm@osdl.org>, Sam Ravnborg <sam@ravnborg.org>,
hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32
Date: Wed, 11 Jan 2006 10:49:38 -0800 [thread overview]
Message-ID: <adairsq1tx9.fsf@cisco.com> (raw)
In-Reply-To: <1137001400.11245.31.camel@camp4.serpentine.com> (Bryan O'Sullivan's message of "Wed, 11 Jan 2006 09:43:19 -0800")
Bryan> I'll take a look at whether the extra call/ret indirection
Bryan> affects performance in a measurable fashion.
Your current implementation is out-of-line, right?
I would be surprised if calling a function has any overhead on x86_64,
since the function call is a jump that can be predicted perfectly.
The only issue is the code to shuffle values into the right registers.
- R.
next prev parent reply other threads:[~2006-01-11 18:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 20:26 [PATCH 0 of 3] 32-bit MMIO copy routine Bryan O'Sullivan
2006-01-06 20:26 ` [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-10 9:18 ` Andrew Morton
2006-01-10 14:55 ` Roland Dreier
2006-01-10 16:07 ` Bryan O'Sullivan
2006-01-10 16:56 ` [PATCH] [RFC] Generic 32-bit MMIO copy, out of line Bryan O'Sullivan
2006-01-10 17:07 ` [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Christoph Hellwig
2006-01-10 17:13 ` Bryan O'Sullivan
2006-01-10 17:49 ` Bryan O'Sullivan
2006-01-10 17:51 ` Christoph Hellwig
2006-01-10 17:55 ` Bryan O'Sullivan
2006-01-10 22:05 ` Andrew Morton
2006-01-10 22:29 ` Bryan O'Sullivan
2006-01-10 23:32 ` Andrew Morton
2006-01-11 17:20 ` Bryan O'Sullivan
2006-01-11 17:22 ` Sam Ravnborg
2006-01-11 17:30 ` Andrew Morton
2006-01-11 17:43 ` Bryan O'Sullivan
2006-01-11 18:49 ` Roland Dreier [this message]
2006-01-11 18:57 ` Bryan O'Sullivan
2006-01-11 19:01 ` Roland Dreier
2006-01-11 19:08 ` Bryan O'Sullivan
2006-01-13 15:19 ` Adrian Bunk
2006-01-10 18:02 ` Randy.Dunlap
2006-01-10 20:04 ` Sam Ravnborg
2006-01-10 15:59 ` Bryan O'Sullivan
2006-01-06 20:26 ` [PATCH 2 of 3] memcpy32 for x86_64 Bryan O'Sullivan
2006-01-06 20:26 ` [PATCH 3 of 3] Add __raw_memcpy_toio32 to each arch Bryan O'Sullivan
-- strict thread matches above, loose matches on Subject: below --
2006-01-10 19:53 [PATCH 0 of 3] 32-bit MMIO copy routines, reworked Bryan O'Sullivan
2006-01-10 19:53 ` [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-11 22:39 [PATCH 0 of 3] MMIO 32-bit copy routine, the final frontier Bryan O'Sullivan
2006-01-11 22:39 ` [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-11 23:43 ` Andrew Morton
[not found] <5s6p8-1O3-29@gated-at.bofh.it>
[not found] ` <5s6p8-1O3-27@gated-at.bofh.it>
[not found] ` <5tnZx-1lb-17@gated-at.bofh.it>
[not found] ` <5tt8U-xV-5@gated-at.bofh.it>
[not found] ` <5tueu-2mb-9@gated-at.bofh.it>
[not found] ` <5tvaH-3MA-55@gated-at.bofh.it>
[not found] ` <5tvX6-4MO-13@gated-at.bofh.it>
[not found] ` <5tvX6-4MO-11@gated-at.bofh.it>
[not found] ` <5tvXa-4MO-23@gated-at.bofh.it>
[not found] ` <5tzQR-2zH-11@gated-at.bofh.it>
2006-01-15 15:33 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adairsq1tx9.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.