From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: yevgenyp@mellanox.co.il, general@lists.openfabrics.org,
netdev@vger.kernel.org
Subject: Re: [ofa-general][PATCH] mlx4_core: Synch catastrophic flow with module unload
Date: Mon, 13 Jul 2009 12:45:32 -0700 [thread overview]
Message-ID: <adak52cv02r.fsf@cisco.com> (raw)
In-Reply-To: <20090713.111407.196601373.davem@davemloft.net> (David Miller's message of "Mon, 13 Jul 2009 11:14:07 -0700 (PDT)")
> Applied, thanks.
Dave, please don't apply mlx4_core patches without giving me a chance to
review them. In this case the patch looks buggy to me: I don't see how
it handles, say, hot remove of one device -- it only handles module
removal. And I would hope we could fix this without adding a global
symbol as namespace polluting as "drv_mutex".
Yevgeny didn't even send this patch to you; he just cc'ed netdev as a
courtesy. However I understand that the physical location of mlx4_core
in drivers/net makes it easy to do this. Maybe this is the best
argument in favor of moving the mlx4_core stuff to drivers/shared?
- R.
next prev parent reply other threads:[~2009-07-13 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 15:27 [ofa-general][PATCH] mlx4_core: Synch catastrophic flow with module unload Yevgeny Petrilin
2009-07-13 18:14 ` David Miller
2009-07-13 19:45 ` Roland Dreier [this message]
2009-07-13 20:09 ` David Miller
2009-07-13 21:53 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak52cv02r.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.