From: Roland Dreier <rdreier@cisco.com>
To: "Giangiacomo Mariotti" <giangiacomo.mariotti@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Misuse of sizeof
Date: Sat, 13 Dec 2008 08:59:10 -0800 [thread overview]
Message-ID: <adak5a41069.fsf@cisco.com> (raw)
In-Reply-To: <2aac3c260812130831m3ec4aa5cm3abd729499727873@mail.gmail.com> (Giangiacomo Mariotti's message of "Sat, 13 Dec 2008 17:31:06 +0100")
> IMO there's a bug in the use of sizeof in /arch/x86/boot/main.c, it's
> also a strange style.
Style is of course a matter of opinion, but sizeof is an operator, not a
function, and as far as I can see, there's no bug in how it is used even
without your patch.
- R.
prev parent reply other threads:[~2008-12-13 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 16:31 [PATCH] Misuse of sizeof Giangiacomo Mariotti
2008-12-13 16:43 ` Frédéric Weisbecker
2008-12-13 17:33 ` Giangiacomo Mariotti
2008-12-13 16:44 ` Miguel Ojeda
2008-12-13 16:48 ` Gregory Petrosyan
2008-12-13 16:59 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak5a41069.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=giangiacomo.mariotti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.