From: Roland Dreier <rdreier@cisco.com>
To: steiner@sgi.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
tglx@linutronix.de, holt@sgi.com, andrea@qumranet.com
Subject: Re: [patch 03/11] GRU Driver - driver internal header files
Date: Mon, 09 Jun 2008 14:38:18 -0700 [thread overview]
Message-ID: <adak5gy70hh.fsf@cisco.com> (raw)
In-Reply-To: <20080609211045.488884093@attica.americas.sgi.com> (steiner@sgi.com's message of "Mon, 09 Jun 2008 16:10:31 -0500")
> +/*
> + * Structure used to pass TLB flush parameters to the driver
> + */
> +struct gru_flush_tlb_req {
> + unsigned long gseg;
> + unsigned long vaddr;
> + size_t len;
> +};
This and other data structures you pass into the kernel via ioctl() are
not 32/64 clean. So a 32-bit process (which can easily run on a 64-bit
x86-64 kernel) will end up sending garbage to the kernel.
next prev parent reply other threads:[~2008-06-09 21:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 21:10 [patch 00/11] GRU Driver steiner
2008-06-09 21:10 ` [patch 01/11] GRU Driver - hardware data structures steiner
2008-06-09 22:52 ` Andrew Morton
2008-06-10 4:07 ` Andi Kleen
2008-06-11 18:57 ` Jack Steiner
2008-06-09 21:10 ` [patch 02/11] GRU Driver - GRU instructions & macros steiner
2008-06-09 21:10 ` [patch 03/11] GRU Driver - driver internal header files steiner
2008-06-09 21:38 ` Roland Dreier [this message]
2008-06-10 14:57 ` Jack Steiner
2008-06-09 21:10 ` [patch 04/11] GRU Driver - kernel services " steiner
2008-06-09 21:10 ` [patch 05/11] GRU Driver - driver initialization, file & vma ops steiner
2008-06-09 21:10 ` [patch 06/11] GRU Driver - page faults & exceptions steiner
2008-06-09 21:10 ` [patch 07/11] GRU Driver - kernel services provide by driver steiner
2008-06-09 21:10 ` [patch 08/11] GRU Driver - resource management steiner
2008-06-09 21:10 ` [patch 09/11] GRU Driver - /proc interfaces steiner
2008-06-09 21:32 ` Roland Dreier
2008-06-09 22:11 ` Jack Steiner
2008-06-10 14:20 ` Roland Dreier
2008-06-09 21:10 ` [patch 10/11] GRU Driver - TLB flushing, MMUOPS callouts steiner
2008-06-09 21:10 ` [patch 11/11] GRU Driver - makefile & Kconfig file changes steiner
2008-06-09 21:35 ` Roland Dreier
2008-06-10 14:41 ` Jack Steiner
2008-06-12 13:27 ` [patch 00/11] GRU Driver Ingo Molnar
2008-06-12 14:05 ` Jack Steiner
2008-06-12 18:03 ` Andrew Morton
2008-06-12 20:52 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak5gy70hh.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=andrea@qumranet.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.