From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64
Date: Thu, 05 Jul 2007 16:32:45 -0700 [thread overview]
Message-ID: <adak5te2zqa.fsf@cisco.com> (raw)
In-Reply-To: <20070705231615.451797310@linux-foundation.org> (Stephen Hemminger's message of "Thu, 05 Jul 2007 16:14:14 -0700")
> --- a/include/asm-i386/scatterlist.h 2007-07-05 14:37:11.000000000 -0700
> +++ b/include/asm-i386/scatterlist.h 2007-07-05 15:44:51.000000000 -0700
> @@ -5,9 +5,9 @@
>
> struct scatterlist {
> struct page *page;
> - unsigned int offset;
> dma_addr_t dma_address;
> - unsigned int length;
> + u16 offset;
> + u16 length;
> };
Actually this struct layout could be even better, since pointers are
32 bits but dma_addr_t may be 64 bits... having
struct scatterlist {
dma_addr_t dma_address;
struct page *page;
u16 offset;
u16 length;
};
would allow struct scatterlist to be 16 bytes. Seems like a good thing...
- R.
next prev parent reply other threads:[~2007-07-05 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 23:14 [RFC 0/2] Convert skb to use scatterlist Stephen Hemminger
2007-07-05 23:14 ` [RFC 1/2] skbuff: " Stephen Hemminger
2007-07-05 23:14 ` [RFC 2/2] shrink size of scatterlist on common i386/x86-64 Stephen Hemminger
2007-07-05 23:32 ` Roland Dreier [this message]
2007-07-05 23:43 ` David Miller
2007-07-06 0:00 ` Stephen Hemminger
2007-07-06 0:15 ` David Miller
2007-07-06 7:43 ` Rusty Russell
2007-07-06 8:54 ` David Miller
2007-07-06 17:14 ` Williams, Mitch A
2007-07-06 19:20 ` David Miller
2007-07-08 16:17 ` Muli Ben-Yehuda
2007-07-09 7:06 ` David Miller
2007-07-09 8:53 ` Muli Ben-Yehuda
2007-07-08 16:11 ` Muli Ben-Yehuda
2007-07-11 23:46 ` Williams, Mitch A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak5te2zqa.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.