From: Roland Dreier <rdreier@cisco.com>
To: Dimitris Michailidis <dm@chelsio.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: cxgb4: Make unnecessarily global functions static
Date: Wed, 21 Apr 2010 12:03:05 -0700 [thread overview]
Message-ID: <adaljcgpr12.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <adapr1spr7e.fsf@roland-alpha.cisco.com> (Roland Dreier's message of "Wed, 21 Apr 2010 11:59:17 -0700")
By the way, this results in the following improvement in size in my
x86-64 build, so it's not just source cleanup:
add/remove: 0/4 grow/shrink: 3/6 up/down: 186/-346 (-160)
function old new delta
static.T 18293 18412 +119
t4_ethrx_handler 649 698 +49
handle_trace_pkt 127 145 +18
t4_wr_mbox_meat 728 722 -6
t4_read_rss 147 140 -7
t4_mc_read 201 187 -14
sf1_write 243 228 -15
sf1_read 279 262 -17
t4_edc_read 240 222 -18
t4_pktgl_free 41 - -41
t4_read_indirect 46 - -46
t4_write_indirect 52 - -52
t4_wait_op_done_val 130 - -130
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
next prev parent reply other threads:[~2010-04-21 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 18:59 cxgb4: Make unnecessarily global functions static Roland Dreier
2010-04-21 19:03 ` Roland Dreier [this message]
2010-04-22 6:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaljcgpr12.fsf@roland-alpha.cisco.com \
--to=rdreier@cisco.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.