From: Roland Dreier <rdreier@cisco.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: markus.lidel@shadowconnect.com, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] I2O: mark i2o_config broken on 64-bit
Date: Sun, 01 Oct 2006 09:11:30 -0700 [thread overview]
Message-ID: <adalko0xbgt.fsf@cisco.com> (raw)
In-Reply-To: <20061001155636.GA6836@havoc.gtf.org> (Jeff Garzik's message of "Sun, 1 Oct 2006 11:56:36 -0400")
> - //TODO 64bit fix
> + //FIXME: broken on 64-bit
> sg[i].addr_bus = (u32) p->phys;
This looks worse than just broken on 64 bit. I didn't even attempt to
understand what's going on here, but would this even work on 32 bit
systems that have physical addresses above 4 gigs (eg i386 with PAE)?
- R.
next prev parent reply other threads:[~2006-10-01 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 15:56 [PATCH] I2O: mark i2o_config broken on 64-bit Jeff Garzik
2006-10-01 16:11 ` Roland Dreier [this message]
2006-10-01 16:45 ` Markus Lidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adalko0xbgt.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.lidel@shadowconnect.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.