From: Roland Dreier <rdreier@cisco.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: <hawkes@sgi.com>, "Andrew Morton" <akpm@osdl.org>,
<linux-kernel@vger.kernel.org>, "Jack Steiner" <steiner@sgi.com>,
"Jes Sorensen" <jes@sgi.com>
Subject: Re: [PATCH] fix alloc_large_system_hash roundup
Date: Wed, 15 Mar 2006 10:41:58 -0800 [thread overview]
Message-ID: <adalkvb35zd.fsf@cisco.com> (raw)
In-Reply-To: <200603151828.k2FISxg19755@unix-os.sc.intel.com> (Kenneth W. Chen's message of "Wed, 15 Mar 2006 10:29:00 -0800")
Kenneth> roundup_pow_of_two uses fls, but fls takes an "int"
Kenneth> argument. I think that function is buggy on 64-bit
Kenneth> arch. Is it an oversight or something?
Huh, looks like you're right. I never looked inside fls() before.
Yes, roundup_pow_of_two() should probably be fixed, since a naive
person (like me) would look at it and think it works on longs.
- R.
prev parent reply other threads:[~2006-03-15 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 17:36 [PATCH] fix alloc_large_system_hash roundup hawkes
2006-03-15 17:40 ` Roland Dreier
2006-03-15 18:29 ` Chen, Kenneth W
2006-03-15 18:41 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adalkvb35zd.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=hawkes@sgi.com \
--cc=jes@sgi.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.