From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: checkpatch, a patch checking script.
Date: Fri, 27 Apr 2007 22:50:37 -0700 [thread overview]
Message-ID: <adaodl9m4ia.fsf@cisco.com> (raw)
In-Reply-To: <20070427221803.2a117c23.akpm@linux-foundation.org> (Andrew Morton's message of "Fri, 27 Apr 2007 22:18:03 -0700")
> box:/usr/src/25> ~/checkpatch.pl patches/git-infiniband.patch
Yup, I ran this too.
> Checking patches/git-infiniband.patch: signoffs = 113
> Use WARN_ON & Recovery code rather than BUG() and BUG_ON()
> 8143:+ BUG_ON(mlx4_ib_alloc_db_from_pgdir(pgdir, db, order));
> 12629:+ BUG_ON(cmd->free_head < 0);
> 16580:+ BUG_ON(index < dev->caps.num_mgms);
> 16665:+ BUG_ON(amgm_index_to_free < dev->caps.num_mgms);
> 16681:+ BUG_ON(index < dev->caps.num_mgms);
I agree -- killing the kernel for a driver bug is dump. I'll remove
all these BUGs before merging.
> Don't init statics to 0/NULL:
> 10333:+ path->static_rate = 0;
This is a false positive/opportunity for script improvement, obviously.
> 15461:+static int msi_x = 0;
> 16113:+ static int mlx4_version_printed = 0;
Already zapped these.
- R.
next prev parent reply other threads:[~2007-04-28 5:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 14:11 [PATCH 0/9] Kconfig: cleanup s390 v2 Martin Schwidefsky
2007-04-23 16:52 ` Arnd Bergmann
2007-04-23 17:45 ` Andrew Morton
2007-04-24 7:52 ` Martin Schwidefsky
2007-04-25 18:21 ` Randy Dunlap
2007-04-25 21:30 ` Andrew Morton
2007-04-26 0:24 ` Andrew Morton
2007-04-26 0:32 ` Arnd Bergmann
2007-04-26 1:06 ` Andrew Morton
2007-04-27 14:21 ` patch style checks Andy Whitcroft
2007-04-27 15:44 ` jschopp
2007-04-26 1:39 ` [PATCH 0/9] Kconfig: cleanup s390 v2 Anton Vorontsov
2007-04-26 8:30 ` Andrew Morton
2007-04-26 20:36 ` Randy Dunlap
2007-04-26 0:39 ` Dave Jones
2007-04-26 2:38 ` Randy Dunlap
2007-04-26 3:02 ` Andrew Morton
2007-04-26 4:24 ` Dave Jones
2007-04-28 3:08 ` checkpatch, a patch checking script Dave Jones
2007-04-28 3:36 ` Roland Dreier
2007-04-28 3:47 ` Adrian Bunk
2007-04-30 0:43 ` Randy Dunlap
2007-04-28 5:18 ` Andrew Morton
2007-04-28 5:50 ` Roland Dreier [this message]
2007-04-28 10:52 ` Andi Kleen
2007-04-28 5:58 ` Roland Dreier
2007-04-28 8:01 ` Jan Engelhardt
2007-04-28 8:16 ` Andrew Morton
2007-04-28 10:53 ` Jan Engelhardt
2007-04-29 23:35 ` Randy Dunlap
2007-04-28 10:48 ` Andi Kleen
2007-04-28 10:02 ` Andrew Morton
2007-04-28 10:15 ` Alan Cox
2007-04-28 11:18 ` Andi Kleen
2007-04-28 11:32 ` Alan Cox
2007-04-28 17:06 ` Dave Jones
2007-04-28 18:11 ` Jeff Garzik
2007-04-30 0:59 ` Randy Dunlap
2007-04-28 16:11 ` Matt Mackall
2007-04-28 17:11 ` Dave Jones
2007-04-28 17:21 ` Matt Mackall
2007-04-29 23:37 ` Randy Dunlap
2007-04-30 0:09 ` Matt Mackall
2007-04-30 0:18 ` Randy Dunlap
2007-04-30 1:59 ` Matt Mackall
2007-04-30 23:59 ` Randy Dunlap
2007-05-02 14:28 ` Geert Uytterhoeven
2007-05-02 15:29 ` Christoph Hellwig
2007-05-02 15:32 ` Geert Uytterhoeven
2007-05-02 19:41 ` Andrew Morton
2007-05-02 19:55 ` Geert Uytterhoeven
2007-05-02 20:29 ` Andrew Morton
2007-05-02 19:08 ` Jan Engelhardt
2007-05-02 19:05 ` Jan Engelhardt
2007-05-03 7:32 ` Sébastien Dugué
2007-05-03 9:27 ` Geert Uytterhoeven
2007-04-26 13:02 ` [PATCH 0/9] Kconfig: cleanup s390 v2 Andy Whitcroft
2007-05-09 11:21 ` Martin Schwidefsky
2007-05-09 16:35 ` Andrew Morton
2007-05-10 7:25 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaodl9m4ia.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.