From: Roland Dreier <rdreier@cisco.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, openib-general@openib.org,
tom@opengridcomputing.com, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Date: Sun, 26 Nov 2006 12:26:08 -0800 [thread overview]
Message-ID: <adapsba2bvj.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0611261208550.3483@woody.osdl.org> (Linus Torvalds's message of "Sun, 26 Nov 2006 12:11:29 -0800 (PST)")
> +#define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1)
> +#define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask))
Fine by me, but it loses the extra (typeof(x)) cast that Al wanted to
make sure that the result of ALIGN() is not wider than x.
- R.
next prev parent reply other threads:[~2006-11-26 20:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-25 5:40 [PATCH] Avoid truncating to 'long' in ALIGN() macro Roland Dreier
2006-11-25 6:07 ` David Miller
2006-11-25 22:56 ` Roland Dreier
2006-11-25 23:05 ` David Miller
2006-11-25 23:09 ` Roland Dreier
2006-11-26 0:41 ` Andrew Morton
2006-11-26 19:09 ` Roland Dreier
2006-11-26 19:10 ` Roland Dreier
2006-11-26 19:17 ` Andrew Morton
2006-11-26 20:06 ` Roland Dreier
2006-11-26 20:11 ` Linus Torvalds
2006-11-26 20:26 ` Roland Dreier [this message]
2006-11-26 21:06 ` Jörn Engel
2006-11-26 22:20 ` Linus Torvalds
2006-11-27 4:41 ` Al Viro
2006-11-26 1:10 ` Al Viro
2006-11-26 1:17 ` Roland Dreier
2006-11-26 1:25 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adapsba2bvj.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=tom@opengridcomputing.com \
--cc=torvalds@osdl.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.