All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error.
Date: Fri, 22 Oct 2010 22:07:56 -0700	[thread overview]
Message-ID: <adar5fhts2b.fsf@cisco.com> (raw)
In-Reply-To: <20101021123705.7604.20848.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org> (Steve Wise's message of "Thu, 21 Oct 2010 07:37:06 -0500")

I applied this, but can you check if there are any alignment/size issues
with 32-bit userspace on 64-bit kernel?  Specifically:

 >  struct iwch_create_cq_resp {
 >  	__u64 key;
 >  	__u32 cqid;
 >  	__u32 size_log2;
 > +	__u32 memsize;
 >  };

this structure now has size 20 on i386 (32-bit) but size 24 on x86-64 I
think so a 64-bit kernel might falsely think that the 32-bit library was
old.

The fix is to add a __u32 reserved field at the end of the struct so it
always gets padded to 24 bytes.  But I don't want to do that to this
patch until you change the userspace library too.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-10-23  5:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 12:37 [PATCH v2] RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error Steve Wise
     [not found] ` <20101021123705.7604.20848.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-10-23  5:07   ` Roland Dreier [this message]
     [not found]     ` <adar5fhts2b.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-25 14:15       ` Steve Wise
     [not found]         ` <4CC590F9.7010608-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-10-25 15:44           ` Roland Dreier
2010-10-25 15:45           ` Steve Wise
     [not found]             ` <4CC5A5FC.9080009-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-10-25 15:55               ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adar5fhts2b.fsf@cisco.com \
    --to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.