From: Roland Dreier <rdreier@cisco.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: swiotlb: Add missing __init annotations
Date: Fri, 02 Jan 2009 12:02:19 -0800 [thread overview]
Message-ID: <adasko1pjck.fsf@cisco.com> (raw)
In-Reply-To: <20090102192502.GF14249@elte.hu> (Ingo Molnar's message of "Fri, 2 Jan 2009 20:25:02 +0100")
> > @@ -186,7 +186,7 @@ static void swiotlb_print_info(unsigned long bytes)
> > * Statically reserve bounce buffer space and initialize bounce buffer data
> > * structures for the software IO TLB used to implement the DMA API.
> > */
> > -void __init
> > +void __init __weak
> > swiotlb_init_with_default_size(size_t default_size)
>
> This change looks unrealted to __init annotation described in the
> changelog. Was it intentional?
Yes, that was a thinko -- somehow while reading it I saw the __init
without __weak as being missing an annotation. Should I resend a fixed
patch?
- R.
next prev parent reply other threads:[~2009-01-02 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 4:18 swiotlb: Add missing __init annotations Roland Dreier
2009-01-01 13:02 ` Sam Ravnborg
2009-01-02 19:25 ` Ingo Molnar
2009-01-02 20:02 ` Roland Dreier [this message]
2009-01-02 20:46 ` Ingo Molnar
2009-01-02 22:36 ` Roland Dreier
2009-01-02 22:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adasko1pjck.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.