From: Roland Dreier <rdreier@cisco.com>
To: ggrundstrom@neteffect.com
Cc: netdev@vger.kernel.org, ewg@lists.openfabrics.org
Subject: Re: [ewg] [PATCH 11/14] nes: OpenFabrics kernel verbs
Date: Wed, 08 Aug 2007 13:10:14 -0700 [thread overview]
Message-ID: <adasl6tokih.fsf@cisco.com> (raw)
In-Reply-To: <200708080119.l781JRc2004874@neteffect.com> (ggrundstrom@neteffect.com's message of "Tue, 7 Aug 2007 20:19:27 -0500")
> +static struct ib_mw *nes_alloc_mw(struct ib_pd *ibpd) {
> + get_random_bytes(&next_stag_index, sizeof(next_stag_index));
Could this use up a lot of entropy? Is random32() sufficient?
> + stag_key = (u8)next_stag_index;
I don't think this cast is needed.
> + if (ret) {
> + return (ERR_PTR(ret));
> + }
Don't need braces for one-line blocks.
> + if (NULL == cqp_request) {
It's more idiomatic to write "if (!cqp_request) {"
prev parent reply other threads:[~2007-08-08 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 1:19 [PATCH 11/14] nes: OpenFabrics kernel verbs ggrundstrom
2007-08-08 20:10 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adasl6tokih.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ewg@lists.openfabrics.org \
--cc=ggrundstrom@neteffect.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.