All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: general@lists.openfabrics.org, linux-next@vger.kernel.org,
	Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Subject: Re: linux-next: infiniband tree build failure
Date: Wed, 29 Apr 2009 09:51:47 -0700	[thread overview]
Message-ID: <adatz471jz0.fsf@cisco.com> (raw)
In-Reply-To: <20090429140101.d9c7467c.sfr@canb.auug.org.au> (Stephen Rothwell's message of "Wed, 29 Apr 2009 14:01:01 +1000")

 > Today's linux-next build (powerpc ppc64_defconfig) produced this new
 > warning:
 > 
 > drivers/infiniband/hw/ehca/hcp_phyp.c: In function 'hcp_galpas_ctor':
 > drivers/infiniband/hw/ehca/hcp_phyp.c:65: warning: assignment makes integer from pointer without a cast
 > 
 > Caused by commit 2bd93ed8b59d9bf8b918a0fa04be50482906c16b ("IB/ehca:
 > Remove unnecessary memory operations for userspace queue pairs").

Thanks for pointing this out.  I rolled the below into the patch in
question, which should fix this.

diff --git a/drivers/infiniband/hw/ehca/hcp_phyp.c b/drivers/infiniband/hw/ehca/hcp_phyp.c
index fc3a245..b3e0e72 100644
--- a/drivers/infiniband/hw/ehca/hcp_phyp.c
+++ b/drivers/infiniband/hw/ehca/hcp_phyp.c
@@ -62,7 +62,7 @@ int hcp_galpas_ctor(struct h_galpas *galpas, int is_user,
 		if (ret)
 			return ret;
 	} else
-		galpas->kernel.fw_handle = NULL;
+		galpas->kernel.fw_handle = 0;
 
 	galpas->user.fw_handle = paddr_user;
 

  parent reply	other threads:[~2009-04-29 16:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29  4:01 linux-next: infiniband tree build failure Stephen Rothwell
2009-04-29  4:04 ` [ofa-general] " Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier [this message]
2009-04-30  3:22   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-05-08  1:53 Stephen Rothwell
2009-11-20  0:03 Stephen Rothwell
2009-11-20  0:19 ` Roland Dreier
2009-11-20  0:30   ` Sean Hefty
2009-11-20  0:30     ` Sean Hefty
2009-11-20  0:43     ` Roland Dreier
2009-11-20  0:43       ` Roland Dreier
2009-11-20  0:45     ` Roland Dreier
2009-11-20  0:45       ` Roland Dreier
2009-11-20  0:52       ` Sean Hefty
2009-11-20  0:52         ` Sean Hefty
2009-11-20  0:34   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adatz471jz0.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ossrosch@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.