From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
Luca Barbieri <luca@luca-barbieri.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems
Date: Sun, 24 Oct 2010 09:20:34 -0700 [thread overview]
Message-ID: <adavd4ro94d.fsf@cisco.com> (raw)
In-Reply-To: <20101022133138.6d82f79a.akpm@linux-foundation.org> (Andrew Morton's message of "Fri, 22 Oct 2010 13:31:38 -0700")
> That's only part of the problem. The following won't build also:
> drivers/infiniband/hw
Interesting... I hadn't looked at that usage before. Both drivers that
seem to use atomic64 already depend on 64BIT in Kconfig, so I suspect
the intersection of 64BIT and !ATOMIC64 is empty?
But eg drivers/infiniband/hw/qib/qib_rc.c does essentially:
atomic64_t *maddr;
u64 sdata = <something>
...
maddr = (atomic64_t *) qp->r_sge.sge.vaddr;
atomic64_add_return(sdata, maddr)
is it legit to cast some random address to atomic64_t and expect it to
work across archs that implement atomic64? (I expect x86_64 is probably
OK but I wonder if other architectures might not be so understanding)
- R.
next prev parent reply other threads:[~2010-10-24 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 17:27 [PATCH] lib/atomic64_test: do not build on non-atomic64 systems Mike Frysinger
2010-10-21 22:02 ` Andrew Morton
2010-10-21 22:23 ` Mike Frysinger
2010-10-21 22:55 ` Andrew Morton
2010-10-21 23:04 ` Mike Frysinger
2010-10-21 23:24 ` Andrew Morton
2010-10-22 20:14 ` Mike Frysinger
2010-10-22 20:31 ` Andrew Morton
2010-10-22 20:47 ` Mike Frysinger
2010-10-22 21:00 ` Andrew Morton
2010-10-22 21:07 ` Mike Frysinger
2010-10-24 16:20 ` Roland Dreier [this message]
2010-10-25 1:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adavd4ro94d.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@luca-barbieri.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.