All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Aleksey Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
Subject: Re: [PATCH] Variable multicast and patch record queues length.
Date: Wed, 12 Jan 2011 10:59:11 -0800	[thread overview]
Message-ID: <adawrma3q4g.fsf@cisco.com> (raw)
In-Reply-To: <4D00BC60.8020505-smomgflXvOZWk0Htik3J/w@public.gmane.org> (Aleksey Senin's message of "Thu, 9 Dec 2010 13:24:16 +0200")

 > Currently only 3 packets stored in the send queue before drop take
 > place. Queue's length may be changed at runtime via files mcast_qlen
 > and prec_qlen files under /sys/module/ib_ipoib/parameters/ directory.

Given that we already have module parameters that can be set at runtime,
do we really need a sysctl too?

 > +	if (!ipoib_table_header)
 > +		ipoib_table_header = register_sysctl_table(ipoib_table);

Seems like unneeded duplication of interfaces (and I don't think an
ipoib-specific sysctl seems like the right thing)

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2011-01-12 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 11:24 [PATCH] Variable multicast and patch record queues length Aleksey Senin
     [not found] ` <4D00BC60.8020505-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-12 18:59   ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adawrma3q4g.fsf@cisco.com \
    --to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org \
    --cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.