All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: "Nelson, Shannon" <shannon.nelson@intel.com>,
	<akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
	<davem@davemloft.net>, <jeff@garzik.org>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Leech, Christopher" <christopher.leech@intel.com>
Subject: Re: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X
Date: Fri, 20 Jul 2007 12:05:24 -0700	[thread overview]
Message-ID: <aday7hac2vf.fsf@cisco.com> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC32903445CD4@orsmsx414.amr.corp.intel.com> (Waskiewicz Jr's message of "Fri, 20 Jul 2007 11:09:03 -0700")

 > Both igb (recently posted) and ixgbe (also recently posted) support both
 > MSI and MSI-X.  Right now when we try to request MSI-X vectors, if we
 > fail to acquire what we've asked for, we fall back to MSI support.  If
 > MSI fails to initialize, we fall back to legacy interrupts.  So it needs
 > to be there in case MSI-X allocation fails for the NIC driver.

Hmm, I see I don't understand what this driver is doing.  What is a
"struct ioatdma_device"?  Is this driver requesting interrupts that
come from the NIC or the IOAT DMA engine?

Anyway, if the NICs support MSI-X, is there any chance of failing to
get one MSI-X vectors but then succeeding in getting MSI enabled?
How could that happen?  I don't see what falling back to MSI buys you
beyond more code.

 - R.

  reply	other threads:[~2007-07-20 19:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20  0:44 [PATCH 0/7] I/OAT: Add support for DCA - Direct Cache Access Shannon Nelson
2007-07-20  0:44 ` [PATCH 1/7] I/OAT: New device ids Shannon Nelson
2007-07-20  0:49   ` David Miller
2007-07-20  0:44 ` [PATCH 2/7] I/OAT: Rename the source file Shannon Nelson
2007-07-20  0:49   ` David Miller
2007-07-20  0:45 ` [PATCH 3/7] I/OAT: code cleanup from checkpatch output Shannon Nelson
2007-07-20  0:49   ` David Miller
2007-07-20  0:45 ` [PATCH 4/7] I/OAT: Split PCI startup from DMA handling code Shannon Nelson
2007-07-20  0:50   ` David Miller
2007-07-20 10:53   ` Andrey Panin
2007-07-20 16:33     ` Nelson, Shannon
2007-07-20  0:45 ` [PATCH 5/7] I/OAT: Add support for MSI and MSI-X Shannon Nelson
2007-07-20  0:51   ` David Miller
2007-07-20 17:43   ` Roland Dreier
2007-07-20 18:09     ` Waskiewicz Jr, Peter P
2007-07-20 19:05       ` Roland Dreier [this message]
2007-07-20 19:19         ` Waskiewicz Jr, Peter P
2007-07-20 19:49           ` Roland Dreier
2007-07-20 21:10             ` Leech, Christopher
2007-07-20 21:21               ` Roland Dreier
2007-07-20 21:32                 ` Manu Abraham
2007-07-20 21:38                   ` Roland Dreier
2007-07-20 21:49                     ` Manu Abraham
2007-07-20 21:54                       ` Nelson, Shannon
2007-07-20 21:59                         ` Manu Abraham
2007-07-20 22:00                           ` Nelson, Shannon
2007-07-20 22:07                           ` Waskiewicz Jr, Peter P
2007-07-20 21:13             ` Nelson, Shannon
2007-07-20  0:45 ` [PATCH 6/7] DCA: Add Direct Cache Access driver Shannon Nelson
2007-07-20  0:52   ` David Miller
2007-07-20 16:35     ` Nelson, Shannon
2007-07-20  0:45 ` [PATCH 7/7] I/OAT: Add DCA services Shannon Nelson
2007-07-20  0:52   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aday7hac2vf.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=akpm@linux-foundation.org \
    --cc=christopher.leech@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.