From: Roland Dreier <rdreier@cisco.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Heiko J Schick <schickhj@de.ibm.com>,
Joachim Fenkes <fenkes@de.ibm.com>,
ppc-dev <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
general@lists.openfabrics.org
Subject: Re: [PATCH] infiniband/ehca: use consistent type
Date: Wed, 07 Jan 2009 11:32:13 -0800 [thread overview]
Message-ID: <adazli2ud36.fsf@cisco.com> (raw)
In-Reply-To: <20081231141453.45d7f2c1.sfr@canb.auug.org.au> (Stephen Rothwell's message of "Wed, 31 Dec 2008 14:14:53 +1100")
If we're going to clean this code up, does it make sense to take it
further? More precisely, your patch does:
@@ -226,7 +226,7 @@ u64 hipz_h_alloc_resource_eq(const struct ipz_adapter_handle adapter_handle,
u32 *eq_ist)
{
u64 ret;
- u64 outs[PLPAR_HCALL9_BUFSIZE];
+ unsigned long outs[PLPAR_HCALL9_BUFSIZE];
u64 allocate_controls;
but every parameter of ehca_plpar_hcall9() is unsigned long, and the
return value is a signed long. So should we change ret to long and all
these other declarations to unsigned long while we're touching the code
here?
- R.
next prev parent reply other threads:[~2009-01-07 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 3:14 [PATCH] infiniband/ehca: use consistent type Stephen Rothwell
2009-01-07 19:32 ` Roland Dreier [this message]
2009-01-07 23:47 ` Stephen Rothwell
2009-01-16 22:36 ` Roland Dreier
2009-01-16 22:46 ` Stephen Rothwell
2009-01-16 22:51 ` Roland Dreier
2009-01-16 23:06 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adazli2ud36.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=schickhj@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.