All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: thockin@google.com, Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Kconfig variable "COBALT" is not defined anywhere
Date: Sun, 03 Jun 2007 13:45:08 -0700	[thread overview]
Message-ID: <adazm3glqcr.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0706031630030.26035@localhost.localdomain> (Robert P. J. Day's message of "Sun, 3 Jun 2007 16:31:08 -0400 (EDT)")

 > > >   there is no Kconfig file which defines the selectable option
 > > > "COBALT", which means that this snippet from drivers/char/nvram.c:
 > > >
 > > > #  if defined(CONFIG_COBALT)
 > > > #    include <linux/cobalt-nvram.h>
 > > > #    define MACH COBALT
 > > > #  else
 > > > #    define MACH PC
 > > > #  endif
 > > > never evaluates to true, therefore making <linux/cobalt-nvram.h>
 > > > fairly useless, at least under the circumstances.

 > > Maybe it should be MIPS_COBALT ?

 > that's the first thing that occurred to me, but that header file is
 > copyright sun microsystems and says nothing about MIPS, so that didn't
 > really settle the issue.  that's why i'd rather someone else resolve
 > this one way or the other.

Actually, looking through the old kernel history, it looks like this
was added by Tim Hockin's (CCed) patch "Add Cobalt Networks support to
nvram driver".  Which added this to drivers/cobalt:

+bool 'Support for Cobalt Networks x86 servers' CONFIG_COBALT

I guess Tim can clear up what's intended...

  reply	other threads:[~2007-06-03 20:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-03 17:17 Kconfig variable "COBALT" is not defined anywhere Robert P. J. Day
2007-06-03 20:23 ` Randy Dunlap
2007-06-03 20:31   ` Robert P. J. Day
2007-06-03 20:45     ` Roland Dreier [this message]
2007-06-03 21:08       ` Tim Hockin
2007-06-03 21:15         ` Robert P. J. Day
2007-06-03 21:38           ` Tim Hockin
2007-06-03 21:50             ` Robert P. J. Day
2007-06-04  3:15               ` Tim Hockin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adazm3glqcr.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rpjday@mindspring.com \
    --cc=thockin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.