From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4D82C28B28 for ; Sat, 8 Mar 2025 09:56:44 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tqqvE-0001ym-Ts; Sat, 08 Mar 2025 09:56:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tqqvD-0001yg-Fy for linux-f2fs-devel@lists.sourceforge.net; Sat, 08 Mar 2025 09:56:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CUH4dDLzT6GtaDsv/fiGFSgDZHjCAeg1TiqX8dahLJs=; b=SjHZixN6rHKgmSMoFeoqcrT3+J VuAQaNwXn9Dp8aza//G0u5jlIW/JI9TkTBbu4bRjzMffqRzWjvukbjo6NW+AeiFeFbpcEVoRAkjEt Nr6SDx5YFxPFXpMP5K8+DV+Ifx4dPdzThgLdG082XiorCHdxVuamzUCYydRxIaEijgac=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CUH4dDLzT6GtaDsv/fiGFSgDZHjCAeg1TiqX8dahLJs=; b=QkaPyEEUvOs46O/Mh+yQm5mjjG SaO/ZQeKIdjxNYOHzxUAHHlSgu9GphAQfA9nhTDWfxIKxwjnz53gqZmM68hB/pkMSe/BxxrWGo3ho /hT8Rdji3S+3JFGO6jv5mOcyYyj2yVn6wpvtXR1assDgwENgO1Wf1X24QtdbjvKfI6hc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tqqv1-0000df-PM for linux-f2fs-devel@lists.sourceforge.net; Sat, 08 Mar 2025 09:56:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 89D565C5598 for ; Sat, 8 Mar 2025 09:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22788C4CEE0; Sat, 8 Mar 2025 09:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741427781; bh=60XBRM5aenNPXo3XHWO87rpYBuXDMcswRuEPm9TqGE4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=AK//zFk7TzNhTPApiVSBFzhf1Xu4kSHH8GNMi1tuLKDYnRagedy3SfCl/n4vp9/aA LYPGdytkFoAwQYYg+JYY+0wzCG+RnnQ8NgoBgNikVzetRIl7n/NtEttTI+u9iC7MJ0 0+h1AISHybOULmTG5BdUja8H8YiX57FXHGMw7Rv9teB2G9UlH37JR5El9dxZivny76 0ajJKCiGBdnugbbGOPneOwGjG6hD8i4+z8LtDKpTgcOguvn68fBYD/3ya1jJo5Q68T X9vDKr0hbcOpvKTAB0/H8nN9XZOEa2UyRvffz4uC4yYNzoHDWC1mcmwVoPuK7MhM/E l2JgGX85UA5cQ== Message-ID: Date: Sat, 8 Mar 2025 17:56:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jaegeuk Kim References: <20250307031838.19164-1-chao@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1tqqv1-0000df-PM Subject: Re: [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2025/3/8 2:10, Jaegeuk Kim wrote: > I meant let's support it conservatively if someone needs to enable > in other platform. Oh, I've updated it, we can control it via mount option now. Thanks, > > On 03/07, Chao Yu wrote: >> Let's disable nat_bits by default. >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/node.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c >> index 56873c41436e..3148d9e44e7f 100644 >> --- a/fs/f2fs/node.c >> +++ b/fs/f2fs/node.c >> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi) >> if (!nm_i->nat_bitmap) >> return -ENOMEM; >> >> + /* disable nat_bits feature by default */ >> + disable_nat_bits(sbi, true); >> + >> err = __get_nat_bitmaps(sbi); >> if (err) >> return err; >> -- >> 2.40.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96FC9BE4F for ; Sat, 8 Mar 2025 09:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741427781; cv=none; b=mh8Z+fKQEHvxaK5WSGBdXlyW54/eTPXkbzqHB0Wmb2k8ioZEIi10od6izvEqcGjVM4dFEVAiUaQANeXGp3Pwta8cpf+wf9+ejzPHNSa9E7uwPRuT4jpS8z+Wke6MTagKaVIal7YVOQNapqV+YpoX/KLuqQ4CdFIoAWLaaOahbpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741427781; c=relaxed/simple; bh=60XBRM5aenNPXo3XHWO87rpYBuXDMcswRuEPm9TqGE4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=Poky2CVvYvUOp0t4hi+tfHfVtWTSKEX3y8r5/500yjzWn2AwkM6vl+B4p0WkZKDKzkqYABIH3vwgMEMI4GXz1oeOOJeoAsIS7203hFJ5QpJPy3tPjMdQmHRm6xvS3EL36VFxl/9udHJoI3XNaYEpCiJgP1exTFJXtz3TWWYqPCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AK//zFk7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AK//zFk7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22788C4CEE0; Sat, 8 Mar 2025 09:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741427781; bh=60XBRM5aenNPXo3XHWO87rpYBuXDMcswRuEPm9TqGE4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=AK//zFk7TzNhTPApiVSBFzhf1Xu4kSHH8GNMi1tuLKDYnRagedy3SfCl/n4vp9/aA LYPGdytkFoAwQYYg+JYY+0wzCG+RnnQ8NgoBgNikVzetRIl7n/NtEttTI+u9iC7MJ0 0+h1AISHybOULmTG5BdUja8H8YiX57FXHGMw7Rv9teB2G9UlH37JR5El9dxZivny76 0ajJKCiGBdnugbbGOPneOwGjG6hD8i4+z8LtDKpTgcOguvn68fBYD/3ya1jJo5Q68T X9vDKr0hbcOpvKTAB0/H8nN9XZOEa2UyRvffz4uC4yYNzoHDWC1mcmwVoPuK7MhM/E l2JgGX85UA5cQ== Message-ID: Date: Sat, 8 Mar 2025 17:56:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: disalbe nat_bits by default To: Jaegeuk Kim References: <20250307031838.19164-1-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/3/8 2:10, Jaegeuk Kim wrote: > I meant let's support it conservatively if someone needs to enable > in other platform. Oh, I've updated it, we can control it via mount option now. Thanks, > > On 03/07, Chao Yu wrote: >> Let's disable nat_bits by default. >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/node.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c >> index 56873c41436e..3148d9e44e7f 100644 >> --- a/fs/f2fs/node.c >> +++ b/fs/f2fs/node.c >> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi) >> if (!nm_i->nat_bitmap) >> return -ENOMEM; >> >> + /* disable nat_bits feature by default */ >> + disable_nat_bits(sbi, true); >> + >> err = __get_nat_bitmaps(sbi); >> if (err) >> return err; >> -- >> 2.40.1