Re: [yocto-patches] [meta-rockchip] [PATCH] tinker-board-3: add

[Michael Opdenacker <michael.opdenacker@rootcommit.com>]

Hi Quentin

Thanks a lot for the review, much appreciated!
You're my top (and favorite) reviewer :)

On 12/18/25 11:46, Quentin Schulz wrote:
>> +# Kernel provided by https://github.com/betafive/meta-linux-mainline/
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-mainline"
>> +PREFERRED_VERSION_virtual/kernel = "6.19-rc1"
>> +
>
> Not sure we really want to do this. Maybe wait for linux-yocto-dev to 
> hit v6.19*? We used to do this for some Radxa board in the past I 
> believe.

Understood, let's wait for 2 more months then ;-)

>
>> +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
>> +
>> +# U-Boot doesn't support Tinker Board 3 so far
>> +# but boots fine when configured for a similar SBC
>> +UBOOT_MACHINE = "soquartz-model-a-rk3566_defconfig"
>
> Can you maybe try generic-rk3568_defconfig instead?

Excellent, it works!
And instead of displaying a wrong board name at boot time, we have 
something correct in U-Boot's output:

Model: Generic RK3566/RK3568
SoC:   RK3566

>> +++ b/conf/machine/tinker-board-3s.conf
>> @@ -0,0 +1,10 @@
>> +# Copyright (C) 2025 Michael Opdenacker 
>> <michael.opdenacker@rootcommit.com>
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +#@TYPE: Machine
>> +#@NAME: Tinker Board 3S RK3566
>> +#@DESCRIPTION: ASUS Tinker Board 3 is a Raspberry Pi like SBC based 
>> on Rockchip RK3566 Processor.
>
> s/Tinker Board 3/Tinker Board 3S.
Fixed, thanks!
>
>> +
>> +require conf/machine/include/tinker-board-3.inc
>> +
>> +KERNEL_DEVICETREE = "rockchip/rk3566-tinker-board-3s.dtb"
>
> Do you know if Asus has provided a way to know at runtime which of the 
> Tinker 3/3S is currently running the software? E.g. via a GPIO or an 
> ADC channel with different voltage values?
>
> This would help us only have one machine for supporting both. In 
> U-Boot, you'd do the auto-detection and load the appropriate device 
> tree based on that.


I don't know, but I can investigate. That would be useful indeed.

>
> We also need an entry in the README for this newly supported board.


Correct, fixed.

>
>> diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend 
>> b/recipes-kernel/linux/linux-yocto_%.bbappend
>> index 2dba3d7..684d33a 100644
>> --- a/recipes-kernel/linux/linux-yocto_%.bbappend
>> +++ b/recipes-kernel/linux/linux-yocto_%.bbappend
>> @@ -30,6 +30,8 @@ COMPATIBLE_MACHINE:rock-pi-e = "rock-pi-e"
>>   COMPATIBLE_MACHINE:rock-pi-s = "rock-pi-s"
>>   COMPATIBLE_MACHINE:rock64 = "rock64"
>>   COMPATIBLE_MACHINE:soquartz = "soquartz"
>> +COMPATIBLE_MACHINE:tinker-board-3 = "tinker-board-3"
>> +COMPATIBLE_MACHINE:tinker-board-3s = "tinker-board-3s"
>
> NACK, it isn't supported, you said it yourself.

Yep, see you in 2 months for a V2 ;-)

Thanks again
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/