From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony.perard@vates.tech>,
Michal Orzel <michal.orzel@amd.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Subject: Re: [PATCH v2 1/2] make ioremap_attr() common
Date: Thu, 9 Apr 2026 09:52:18 +0200 [thread overview]
Message-ID: <addasqowkczVjsE4@macbook.local> (raw)
In-Reply-To: <72526f3a-726a-4a1e-8d80-1a336175c1af@suse.com>
On Wed, Apr 08, 2026 at 02:07:23PM +0200, Jan Beulich wrote:
> This core backing function is uniform; what varies across architectures
> are the attributes passed and hence the wrappers around it. Yet of course
> extra checking or special handling may be needed per arch, so introduce a
> suitable hook.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Just looked at the common and x86 bits, both LGTM.
> ---
> Declarations (or inline counterparts) aren't being moved around, to avoid
> the need to touch source files using the functions. Quite possibly they
> want to consistently go into xen/io.h and asm/io.h.
>
> Of course ioremap.c could also go into lib/.
Maybe I'm missing the point, but what's the benefit for it to go into
lib/? Is there any realistic scenario where we might have a
functional hypervisor build that doesn't require ioremap?
Thanks, Roger.
next prev parent reply other threads:[~2026-04-09 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:05 [PATCH v2] ioremap() et al Jan Beulich
2026-04-08 12:07 ` [PATCH v2 1/2] make ioremap_attr() common Jan Beulich
2026-04-09 7:26 ` Luca Fancellu
2026-04-09 7:54 ` Jan Beulich
2026-04-09 7:52 ` Roger Pau Monné [this message]
2026-04-09 7:58 ` Jan Beulich
2026-04-09 8:36 ` Oleksii Kurochko
2026-04-08 12:09 ` [PATCH v2 2/2] make ioremap_wc() x86 only (for the time being) Jan Beulich
2026-04-09 7:57 ` Luca Fancellu
[not found] ` <4291DA48-87D9-491B-83C6-51CCACC0FFE7@arm.com>
2026-04-09 8:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=addasqowkczVjsE4@macbook.local \
--to=roger.pau@citrix.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=connojdavis@gmail.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.