All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@virtuozzo.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Andrey Drobyshev" <andrey.drobyshev@virtuozzo.com>
Cc: qemu-devel@nongnu.org, philmd@oss.qualcomm.com, den@openvz.org
Subject: Re: [PATCH 0/3] hw/display/qxl: Avoid crashing on stale guest addresses in qxl_post_load
Date: Wed, 26 Aug 2026 15:26:25 +0200	[thread overview]
Message-ID: <adf69f78-6fbb-4b77-a1cf-e652e906cdc8@virtuozzo.com> (raw)
In-Reply-To: <CAJ+F1CKwNr=6wVaO+tXa876EzoPjYfQC3qx=em3C4BSW7wRC8Q@mail.gmail.com>

On 8/26/26 10:10, Marc-André Lureau wrote:
> Hi Andrey
>
> On Tue, Aug 25, 2026 at 9:26 PM Andrey Drobyshev
> <andrey.drobyshev@virtuozzo.com> wrote:
>> We've experienced crashes when spice-server aborts on migration target
>> when processing an invalid/stale guest address pointer.  While those are
>> hard to reproduce, it seems they can be fairly easily avoided by simply
>> skipping commands with invalid addresses in qxl_post_load.
> I would rather try to find the root cause, rather than applying a
> post-load workaround. It may be related to this issue
> https://gitlab.com/qemu-project/qemu/-/work_items/3766 (confidential):
> there is a lack of resource tracking, when a guest release
> slot/cursors etc, the track commands may not be correctly updated - or
> preventing resource release. Unfortunately, spice/qxl is no longer
> maintained - we should clearly mark this device as unsecure imho.

Unfortunately we do not have access to this item in gitlab.
Can you grant it at least to den@openvz.org?

Den


  parent reply	other threads:[~2026-08-26 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 17:20 [PATCH 0/3] hw/display/qxl: Avoid crashing on stale guest addresses in qxl_post_load Andrey Drobyshev
2026-08-25 17:20 ` [PATCH 1/3] hw/display/qxl: factor out qxl_guest_phys2virt() Andrey Drobyshev
2026-08-25 17:20 ` [PATCH 2/3] hw/display/qxl: validate replayed commands in qxl_post_load Andrey Drobyshev
2026-08-25 17:20 ` [PATCH 3/3] hw/display/qxl: trace skipped stale loadvm commands Andrey Drobyshev
2026-08-26  8:10 ` [PATCH 0/3] hw/display/qxl: Avoid crashing on stale guest addresses in qxl_post_load Marc-André Lureau
2026-08-26  9:47   ` Andrey Drobyshev
2026-08-26 13:26   ` Denis V. Lunev [this message]
2026-09-12 11:52 ` Marc-André Lureau
2026-09-14 13:57 ` Michael Tokarev
2026-09-14 14:11   ` Andrey Drobyshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf69f78-6fbb-4b77-a1cf-e652e906cdc8@virtuozzo.com \
    --to=den@virtuozzo.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.