Re: [PATCH] VT-d: avoid multi-message-MSI check for HPET

["Roger Pau Monné" <roger.pau@citrix.com>]

On Wed, Apr 01, 2026 at 02:47:48PM +0200, Jan Beulich wrote:
> Having this immediately below a PCI-dev vs HPET conditional is (mildly)
> confusing. Move that if() into the body of the earlier one.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -513,13 +513,13 @@ static int msi_msg_to_remap_entry(
>  
>          if ( rc )
>              return rc;
> +
> +        if ( msi_desc->msi_attrib.type == PCI_CAP_ID_MSI )
> +            nr = msi_desc->msi.nvec;
>      }
>      else
>          set_hpet_source_id(msi_desc->hpet_id, &new_ire);
>  
> -    if ( msi_desc->msi_attrib.type == PCI_CAP_ID_MSI )
> -        nr = msi_desc->msi.nvec;
> -

I'm not fully opposed to this, but maybe it would be good to add a
small comment to note that HPET never use multi-vector MSI?

Thanks, Roger.