From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89C94F459E7 for ; Fri, 10 Apr 2026 15:02:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wBDNU-0004Gq-Fb; Fri, 10 Apr 2026 11:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBDNT-0004EJ-6j for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:02:35 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wBDNR-00013C-L9 for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:02:34 -0400 Received: from example.com (unknown [167.220.208.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 628AF20B710C; Fri, 10 Apr 2026 08:02:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 628AF20B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775833351; bh=ObFwLXSfg3jNCgdwQVBI5LkJM0+S7ryTW7yysNqlMEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dg1+2+dRm8vi7JYiyDHc0y+sv9I3VvqKOJKuGMN9UU/5SPqJ9Ul9R3YnZFtd+aDTP C2fQ64IC23ab/KeSOB+cybhp/3Lv1rRAEbjlfzCOeQfvWeYPVQIx65bAIwfS2Lc4aA ZhOq2fpv15gKwT4eWERM0Na5oAhLFftUStq/rwkI= Date: Fri, 10 Apr 2026 17:02:27 +0200 From: Magnus Kulke To: Aastha Rawat Cc: qemu-devel@nongnu.org, Wei Liu Subject: Re: [PATCH 2/2] accel/mshv: return correct errno value from ioeventfd failure Message-ID: References: <20260409-fix_ioevent-v1-0-053b810ae6fb@linux.microsoft.com> <20260409-fix_ioevent-v1-2-053b810ae6fb@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409-fix_ioevent-v1-2-053b810ae6fb@linux.microsoft.com> Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 09, 2026 at 11:53:07AM +0000, Aastha Rawat wrote: > Returning the raw ioctl return value results in misleading error > message. Ensure that actual failure reason is propagated by returning > -errno for ioeventfd failure. > > Signed-off-by: Aastha Rawat > --- > accel/mshv/mshv-all.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c > index e1a8d62f8d..58af674bd9 100644 > --- a/accel/mshv/mshv-all.c > +++ b/accel/mshv/mshv-all.c > @@ -275,7 +275,12 @@ static int ioeventfd(int vm_fd, int event_fd, uint64_t addr, Datamatch dm, > } > } > > - return ioctl(vm_fd, MSHV_IOEVENTFD, &args); > + int ret = ioctl(vm_fd, MSHV_IOEVENTFD, &args); > + if (ret < 0) { > + return -errno; > + } > + > + return ret; > } > > static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr, > Reviewed-by: Magnus Kulke